Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Unable to built Next.js since upgrading to v2 #11

Closed
peduarte opened this issue Jul 10, 2020 · 6 comments
Closed

Unable to built Next.js since upgrading to v2 #11

peduarte opened this issue Jul 10, 2020 · 6 comments
Labels
question Further information is requested

Comments

@peduarte
Copy link

peduarte commented Jul 10, 2020

Hey @kripod

As you probably have seen I've been contributing to Stitches recently to help test it and make sure things are working as users would expect.

@christianalfoni has been working on improving the types and as part of the latest Stitches release, he upgraded to react-polymorphic-box v2.0.3

Since this upgrade, I'm unable to get my Next.js project to build correctly. Things were working fine before that. We suspect it's something to do with the new build strategy used in v2.

I've abstracted a reproducible branch in this repo which you're free to clone and test it out.

Do you think this could be related to the latest release?

Let me know if there's any way I can help.

@peduarte peduarte added the question Further information is requested label Jul 10, 2020
@kripod
Copy link
Owner

kripod commented Jul 10, 2020

Hello,

Thank you for reporting! For v2, I’ve changed the bundling and distribution mechanism. Unfortunately, this may have resulted in broken builds in some environments.

Currently, I’m on a vacation for 3 days, so I will take a look at package.json (e.g. ‘cjs’ vs. ‘mjs’ file extensions and the use of "type": "module") as soon as I get home.

@peduarte
Copy link
Author

peduarte commented Jul 10, 2020

@kripod sure, no rush. Thanks and enjoy the holidays! We've done a patch on our side for now 👍

@kripod
Copy link
Owner

kripod commented Jul 10, 2020

Lovely, thank you! 🙌

May I ask how the patch works? That may take us closer to resolving the situation.

@peduarte
Copy link
Author

This is the commit for it. It reverts to v1 😄

Plus it adds the types that Christian had added in this PR

@kripod kripod closed this as completed in 08fdeef Jul 12, 2020
@kripod
Copy link
Owner

kripod commented Jul 12, 2020

This should be resolved by v2.0.4. Thank you for reporting and please reach out if you encounter any further issues.

Christian and you are doing awesome work with Stitches. I hope it will get big, especially with the recently added support for object syntax.

@peduarte
Copy link
Author

Thanks @kripod will test it and get back to you! :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
question Further information is requested
Projects
None yet
Development

No branches or pull requests

2 participants