Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filtering for train/val/test splits #7

Closed
RemyLau opened this issue Aug 23, 2021 · 1 comment
Closed

Filtering for train/val/test splits #7

RemyLau opened this issue Aug 23, 2021 · 1 comment
Labels
wontfix This will not be worked on

Comments

@RemyLau
Copy link
Collaborator

RemyLau commented Aug 23, 2021

https://github.com/krishnanlab/NetworkLearningEval/blob/1a75b5b1e4525dce81e261d33d13c151cf595135/src/NLEval/label/LabelsetCollection.py#L344-L351

There is a potential issue with the current scheme that would lead to unnecessary removal of label sets. For example, in an iteration, multiple labelsets are to be removed by the LabelsetRangeFilterTrainTestPos filter, but some of them might be okay after reassigning the train/val/test splits.

One potential solution would be reassigning train/val/test splits after every removal of a labelset. However, this poses potential issues such as slower runtime, and also the ordering of removal, which might also lead to different final solution.

@RemyLau RemyLau added the wontfix This will not be worked on label Jan 8, 2022
@RemyLau
Copy link
Collaborator Author

RemyLau commented Jan 8, 2022

The optimal solution (for removing the least amount of data to make the split fulfilling the criterion) might not be trivial to obtain. Also given that SplitLSC is deprecated soon, see #72, this won't be needed anyways.

@RemyLau RemyLau closed this as completed Jan 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
wontfix This will not be worked on
Projects
None yet
Development

No branches or pull requests

1 participant