Add type annotations for closure-compiler support #117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
krisk
reviewed
Nov 16, 2016
| @@ -20,7 +20,8 @@ | |||
| ;(function (global) { | |||
| 'use strict' | |||
|
|
|||
| function log () { | |||
| /** @param {...*} var_args */ | |||
| function log (var_args) { | |||
There was a problem hiding this comment.
Is this change necessary? Not a huge fan of this.
There was a problem hiding this comment.
So apparently this works too - I didn't know that until I tried it just now:
/** @type {function(...*) */
function log() {}
krisk
reviewed
Nov 16, 2016
| for (i = 0, keys = ['searchFn', 'sortFn', 'keys', 'getFn', 'include', 'tokenSeparator'], len = keys.length; i < len; i++) { | ||
| key = keys[i] | ||
| this.options[key] = options[key] || defaultOptions[key] | ||
| for (key in defaultOptions) { |
There was a problem hiding this comment.
I actually didn't have a choice. Closure-compiler renames properties in ADVANCED mode and breaks these references without this refactor. Glad you like it this way.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm using Fuse in a project with Closure-Compiler using
ADVANCEDoptimizations. The fuse code was extremely close to being fully compatible. Just a couple type annotations are needed.The only actual code changes required was initializing the initial options object was using reflection. I changed that in a way that is compatible with the compiler.