Add filter for c version of jsmin #707
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| 2 => array('pipe', 'w') | ||
| ); | ||
|
|
||
| $process = proc_open($this->jsminBin, $descriptorspec, $pipes); |
There was a problem hiding this comment.
Please use the Process component rather than using proc_open directly (which is very tricky to make work cross-platform because it has lots of quirks)
|
Updated the filter to use the I was having issues getting this to work with |
| $tmpAssetFile = tempnam(sys_get_temp_dir(), 'assetic_cjsmin_'); | ||
| file_put_contents($tmpAssetFile, $asset->getContent()); | ||
|
|
||
| $process = new Process($this->jsminBin . ' < ' . $tmpAssetFile); |
There was a problem hiding this comment.
does this work on Windows too ?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is faster than the php JSMin implementation.