Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scenarios will need updating with new powerfulseal code #19

Closed
paigerube14 opened this issue Jun 16, 2020 · 3 comments
Closed

Scenarios will need updating with new powerfulseal code #19

paigerube14 opened this issue Jun 16, 2020 · 3 comments
Assignees

Comments

@paigerube14
Copy link
Collaborator

While I was looking at trying to add code to powerfulseal for the regex namespace issue I opened (powerfulseal/powerfulseal#274) I noticed that the latest python pip package is very outdated compared to the code in github.

There are a couple of RC releases that you are able to install if given the version numbers. Seen here

Trying to test my code I had to completely rewrite the the pod kill scenario. As you can see in the documentation here it no longer has the podScenario and nodeScenario sections, it is just one common scenarios section.

These changes are not too huge but will have to be done at some point in the future.

Examples:
2.9.0 scenario
3.0.* scenario

We will need to make updates to our scenarios when the pip package updates from the current 2.9.0 version.

@chaitanyaenr
Copy link
Collaborator

Nice catch @paigerube14. Let's hard code the version in the requirements.txt to install the latest version ( 3.0.0rc9 ) provided it's stable and update the configs to use the latest syntax to avoid adding more configs following the old syntax from 2.9.0 version. Thoughts?

@paigerube14
Copy link
Collaborator Author

I think that's a good idea! From what I've seen there wasn't much difference between 3.0.0rc4, 3.0.0rc8, and 3.0.0rc9. I think if we set one of those numbers as the default and then we can make the scenario changes and then hopefully it won't have any more huge changes in the near future

@chaitanyaenr
Copy link
Collaborator

Fixed by #20. Thanks @paigerube14.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants