Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Single quotes in property values not preserved #50

Closed
benjamn opened this issue Feb 6, 2012 · 9 comments
Closed

Single quotes in property values not preserved #50

benjamn opened this issue Feb 6, 2012 · 9 comments

Comments

@benjamn
Copy link

benjamn commented Feb 6, 2012

CSS such as this

div {
  label: 'a b';
}

is being compiled to this

div{label:a b}

when this

div{label:'a b'}

is what should be produced.

@benjamn
Copy link
Author

benjamn commented Feb 6, 2012

I tried simply changing the StringValue.__str__ method to add in single quotes, but it looks like StringValue is used for values that are not strings, such as the !important modifier.

@epegzz
Copy link

epegzz commented Aug 20, 2012

+1

@epegzz
Copy link

epegzz commented Aug 20, 2012

Patch works for me, thx! :-)

Any reason why this did not get merged yet?

@eevee
Copy link
Collaborator

eevee commented May 3, 2013

I believe Kronuz is relying on this behavior in his own Sass codebase to work around #146. Once I fix that, I can fix this, with the caveat that it'll break code relying on either incorrect behavior. Alas.

@eevee
Copy link
Collaborator

eevee commented Jul 10, 2013

Brazenly fixed in the development branch.

@eevee
Copy link
Collaborator

eevee commented Jul 10, 2013

Which has now become master.

@eevee eevee closed this as completed Jul 10, 2013
@Huuuze
Copy link

Huuuze commented Dec 18, 2013

This issue is back again. @eevee, any thoughts?

@eevee
Copy link
Collaborator

eevee commented Dec 18, 2013

@Huuuze Can you be more specific? Nothing has changed since 1.2 went out and the case in the ticket works for me.

@Huuuze
Copy link

Huuuze commented Dec 19, 2013

Disregard @eevee -- I had 1.1.5 installed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants