-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/controller handler #13
Conversation
General commennts:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've left another batch of comments, since for some reason github showed the previous ones as outdated. Hopefully I did it right this time!
The maps vectors changed to a struct, possibly should change them into a class
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Other than a few typos here and there, this looks fine to me now, I'll approve, just make sure to test this again later because a lot of stuff was changed, and there's always a chance I've missed something
Kudos, SonarCloud Quality Gate passed! |
No description provided.