Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

There is no Replace ASCII mode #20

Closed
i28v opened this issue Oct 17, 2020 · 5 comments
Closed

There is no Replace ASCII mode #20

i28v opened this issue Oct 17, 2020 · 5 comments
Assignees

Comments

@i28v
Copy link

i28v commented Oct 17, 2020

There is Append ASCII mode, Insert ASCII mode and just plain replace mode without ASCII, can you add this? Thanks.

@krpors krpors closed this as completed in 788c330 Oct 20, 2020
@krpors krpors self-assigned this Oct 20, 2020
@krpors krpors reopened this Oct 20, 2020
@krpors krpors closed this as completed in b6ccdbc Oct 20, 2020
@krpors
Copy link
Owner

krpors commented Oct 20, 2020

Hi, thank you for your interest and report. I've added a patch on the develop branch. If you could check it out if and report back, then I can fully close the issue and merge it to master. The mode can be triggered with R (capital r, shift+r).

@krpors krpors reopened this Oct 20, 2020
@krpors krpors closed this as completed Nov 10, 2020
@alexhenrie
Copy link

hx is definitely my favorite TUI hex editor. I liked it so much that I made an AUR package for it yesterday. However, there hasn't been a release of hx in 6 years, and it would be worth making a new release so that the packaged version has the Replace ASCII feature.

@krpors
Copy link
Owner

krpors commented Oct 27, 2023

Thanks for the kind words. I just merged develop to master and tagged it as v1.0.13. See if that solves your issue.

And the reason for not having a release is because for my use-cases it has been feature complete. However, I'm all ears for feature requests and such :)

@alexhenrie
Copy link

That's great! One more thing: Could you please add a note about the R key (capital R or Shift+R) to the README and :help screen as well?

Actually, I do have one more wishlist feature beyond that: In Vim, :wq writes the file and closes (:wq! also works). If it's too much trouble, I could try to implement that myself and send you a pull request.

@krpors
Copy link
Owner

krpors commented Oct 30, 2023

Sure, I can look into it. Next time however, please make a new issue instead of responding to an already closed issue :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants