You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
In src/main/java/com/autotune/analyser/recommendations/engine/RecommendationEngine.java we have a function populateRecommendation which is receiving a notification object and yet creating a new arraylist with name engineNotifications
// build the engine level notifications here
ArrayList<RecommendationNotification> engineNotifications = new ArrayList<>();
These engineNotifications are added to recommendationModel object
// set the engine level notifications here
for (RecommendationNotification recommendationNotification : engineNotifications) {
recommendationModel.addNotification(recommendationNotification);
}
While the PR #1156 adds the mechanism to add notifications in the notifications to recommendationModel I feel the notifications added to engineNotifications can be added to notifications object as they are getting added to recommendationModel in the end.
In
src/main/java/com/autotune/analyser/recommendations/engine/RecommendationEngine.java
we have a functionpopulateRecommendation
which is receiving a notification object and yet creating a new arraylist with nameengineNotifications
These
engineNotifications
are added torecommendationModel
objectWhile the PR #1156 adds the mechanism to add notifications in the
notifications
torecommendationModel
I feel the notifications added toengineNotifications
can be added tonotifications
object as they are getting added torecommendationModel
in the end.@dinogun @msvinaykumar @khansaad Please let me know your views on this. Thanks in advance!
The text was updated successfully, but these errors were encountered: