Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Choose a color pallete for batted ball trajectories #76

Open
kruser opened this issue Apr 23, 2014 · 2 comments
Open

Choose a color pallete for batted ball trajectories #76

kruser opened this issue Apr 23, 2014 · 2 comments

Comments

@kruser
Copy link
Owner

kruser commented Apr 23, 2014

See the screenshots below. The default color pallet from highcharts is a bit too pastel for our site. For this issue we need to get a color value for the following and apply it to the charts shown.

  • grounders
  • flyballs
  • liners
  • popups

image

image

@albertlyu
Copy link
Contributor

By the way, the order of trajectory displayed in the charts are not consistent when you toggle between different filters or players. See Clayton Kershaw's balls in play allowed in 2012 vs. 2013 below:

image

Edit: Yes, that does look like a grounder at X,Y coordinates (0,0), obviously a data error from upstream.

@kruser
Copy link
Owner Author

kruser commented Apr 23, 2014

Good catch. We should sort the series first to ensure order.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants