Codebase synchronization against jruby-1_7 #43
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Feb 10, 2014
|
@abstractj Things fail on jruby-head? |
|
@vipulnsward that was added due to the issues on Travis travis-ci/travis-ci#1502 with RVM. Now that RVM was updated, I did the rollback. |
|
@abstractj Seems hmac specs are erroring out on jruby-head. |
| @@ -1,12 +1,13 @@ | |||
| module Krypt | |||
| class HMAC | |||
| include Krypt::Helper::XOR | |||
There was a problem hiding this comment.
@abstractj just trying to get a hang of things here. This was replaced by Martin. You reverted this for some reason?
|
@vipulnsward sorry, I missed that. You are correct, it doesn't make sense Speaking about jruby-head master will fail I guess for different reasons, look this is the output from master https://travis-ci.org/krypt/krypt/jobs/18268779#L6565 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.