Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add optional Prometheus metrics collection #21

Closed
wants to merge 1 commit into from

Conversation

paulsturgess
Copy link
Contributor

This collector can be used by apps using the yabeda and yabeda-rails gems.

For example, in initializers/apia.rb

require 'apia/prometheus_collector'

@paulsturgess paulsturgess self-assigned this Jan 2, 2024
@paulsturgess
Copy link
Contributor Author

@adamcooke @jimeh this code is lifted from Identity and putting it inside the Apia gem itself is a simple way for us to re-use it across apps. But alternatively we could create a new dedicated apia-prometheus gem. Do you have any preferences on which approach we take?

This collector can be used by apps using yabeda and yabeda-rails gems.

For example, in initializers/apia.rb

require 'apia/prometheus_collector'
@jimeh
Copy link
Contributor

jimeh commented Jan 22, 2024

@paulsturgess my preference would be a separate gem, so we don't impose metrics-specific gem dependencies on applications that don't need any metrics features out of Apia.

@paulsturgess
Copy link
Contributor Author

my preference would be a separate gem, so we don't impose metrics-specific gem dependencies on applications that don't need any metrics features out of Apia.

OK no problem, thought you might say that. Just didn't want to go ahead and set all that up if we didn't need it. But I can go ahead and do that 👍

@jimehk jimehk deleted the prometheus branch March 16, 2024 18:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants