Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support babel 7 #13

Closed
graingert opened this issue Mar 24, 2018 · 9 comments
Closed

Support babel 7 #13

graingert opened this issue Mar 24, 2018 · 9 comments

Comments

@graingert
Copy link

No description provided.

@xtuc
Copy link

xtuc commented Mar 24, 2018

Please let me know of I can help with something about that.

@krzkaczor
Copy link
Owner

@xtuc is there a nice migration guide somewhere? or could you point me to another not-so-complicated plugin that start supporting babel@7 so i can take a closer look at diff? Thanks :)

@xtuc
Copy link

xtuc commented Mar 29, 2018

We have http://babeljs.io/blog/2017/03/01/upgrade-to-babel-7-for-tool-authors but it's not really up-to-date.

I would suggest you using https://github.com/babel/babel-upgrade.

@mfila
Copy link
Contributor

mfila commented Jul 30, 2018

I've tried to upgrade the plugin to babel 7. Tests still pass. See https://github.com/mfila/babel-plugin-tailcall-optimization/tree/babel7.

All it takes has been:

  1. removing old packages
  2. installing new ones (replacing babel-preset-es2015 with babel-preset-env, and moving babel-core from peerDependencies to devDependencies)
  3. upgrading to @babel namespace in a couple of places

@xtuc
Copy link

xtuc commented Jul 30, 2018

@mfila, yeah thanks that looks good!

@krzkaczor
Copy link
Owner

krzkaczor commented Jul 30, 2018

@mfila shieeet, nice :D Do you want to make a PR? to alternative branch like next? I can get this published.

@mfila
Copy link
Contributor

mfila commented Jul 30, 2018

@krzkaczor yes... an alternative branch would be great, thanks!

@mfila mfila mentioned this issue Aug 7, 2018
@mfila
Copy link
Contributor

mfila commented Aug 7, 2018

I've updated my branch to use Babel 7 beta.56 before making the PR

@krzkaczor
Copy link
Owner

@mfila thanks so much for your contribution!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants