Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cygwin //server/path paths do not work #757

Closed
gisburn opened this issue Jul 2, 2024 · 3 comments
Closed

Cygwin //server/path paths do not work #757

gisburn opened this issue Jul 2, 2024 · 3 comments
Labels
bug Something is not working

Comments

@gisburn
Copy link

gisburn commented Jul 2, 2024

Cygwin //server/path path support (for example used by SMB or https://github.com/kofemann/ms-nfs41-client) is not compiled in by default when building ksh93 1.0.8.

@gisburn
Copy link
Author

gisburn commented Jul 2, 2024

Attached ( ksh_1_0_8_libast_Cygwin_set_PATH_LEADING_SLASHES_for_UNC_paths.patch.gz ) fixes the issue (same patch as https://github.com/kofemann/ms-nfs41-client/blob/master/cygwin/cygwin_ksh93/ksh_1_0_8_libast_Cygwin_set_PATH_LEADING_SLASHES_for_UNC_paths.patch ).

Please keep the comments intact.

I can write a test module on demand (please open a separate issue for that).

@McDutchie
Copy link

I had noticed that patch in your repo. :-) So I actually just fixed it in a less hacky way, in 5188590. Once you can get ksh to build on cygwin (see #758) I would expect it to work now, please comment here if it still doesn't.

@McDutchie McDutchie added blocker This had better be fixed before releasing bug Something is not working and removed blocker This had better be fixed before releasing labels Jul 2, 2024
@gisburn
Copy link
Author

gisburn commented Jul 3, 2024

I had noticed that patch in your repo. :-) So I actually just fixed it in a less hacky way, in 5188590. Once you can get ksh to build on cygwin (see #758) I would expect it to work now, please comment here if it still doesn't.

Seems to be working now with ksh93 v1.0.9 (after bypassing the Cygwin DLL+mamake issues):

$ cd //dernt10srv1fs10.global.loc/copy
$ pwd
//dernt10srv1fs10.global.loc/copy

Thank you ... :-)
... the bug can be closed as "FIXED".

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something is not working
Projects
None yet
Development

No branches or pull requests

2 participants