If file selection is cancelled during ksnip's file open dialog via tray icon, ksnip closes.

[erenseymen]

Steps:

1. Right click on tray icon
2. Select "Open"
   -- File selection window appears.
3. Click on "Cancel" button in file selection window or close the file selection window
   -- ksnip crashes. FAIL

Note: I ran ksnip from terminal and there were no logs about the issue.
Note: If I use File>Open menu in the main window, there is no issue.

ksnip Version: 1.8.0 (Build: 1578-d84ec1a)
OS: Xubuntu 20.10
DE: Xfce 4.14
ksnip config file: ksnip.zip

[fnkabit]

Issue only happens when the main window is hidden.
QFileDialog::getOpenFileNames terminates the application. Happens because the last window is closed.
Working on a fix.

[DamirPorobic]

I can't reproduce this issue on my side, running OpenSUSE with KDE Plasma. Might be effecting only specific Distros.

[DamirPorobic]

PR merged, should be fixed now in continuous build.

[fnkabit]

I can't reproduce this issue on my side, running OpenSUSE with KDE Plasma. Might be effecting only specific Distros.

I'm also running OpenSuse 15.2 KDE. For me, the issue occurs when the MainWindow is closed to system tray and you trigger the open action from system tray.

[DamirPorobic]

Strange, tried exactly that and it stayed open. I'm using the exact same OS version like you.

Now you don't get the issue anymore with master?

[fnkabit]

I didn't get to test with the merged master branch (and I'm away from the keyboard for the next few hours), but I tested both PRs and it worked fine with the fix.

…

On Tue, Dec 15, 2020, 09:58 Damir Porobić ***@***.***> wrote: Strange, tried exactly that and it stayed open. I'm using the exact same OS version like you. Now you don't get the issue anymore with master? — You are receiving this because you were assigned. Reply to this email directly, view it on GitHub <#503 (comment)>, or unsubscribe <https://github.com/notifications/unsubscribe-auth/AROSGQM5UA3LOKUZQA73SD3SU4JJFANCNFSM4UZ2HQYQ> .