Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop node-gyp dependency #19

Closed
kpcyrd opened this issue Nov 7, 2016 · 1 comment
Closed

Drop node-gyp dependency #19

kpcyrd opened this issue Nov 7, 2016 · 1 comment

Comments

@kpcyrd
Copy link

kpcyrd commented Nov 7, 2016

hello,

I'm interested in adding rados as a dependency to my project, but it's dependency list is significant due to node-gyp, which, as far as I know, isn't required. (see scrypt).

Could you please drop this dependency?
@ksperis
Copy link
Owner

ksperis commented Nov 8, 2016

You're right, this dependence could be removed. Node-gyp need to be globally installed.
I removed it here : 7aeb999
Thanks

@ksperis ksperis closed this as completed Nov 8, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@ksperis @kpcyrd