Skip to content
This repository has been archived by the owner on Nov 21, 2023. It is now read-only.

Migrate to now 2 #31

Merged
merged 1 commit into from
May 3, 2019
Merged

Migrate to now 2 #31

merged 1 commit into from
May 3, 2019

Conversation

kt3k
Copy link
Owner

@kt3k kt3k commented May 3, 2019

Now 2 was released in Nov 2, 2018. It's a wrapper of AWS Lambda unlike Now 1. We're still able to use express.js in it by using @now/node-server builder. But I think that's not the way Now 2 recommend. So I separated endpoints into several small micro apps and made them into separate lambda endpoints.

@codecov
Copy link

codecov bot commented May 3, 2019

Codecov Report

Merging #31 into master will decrease coverage by 2.23%.
The diff coverage is 84.58%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #31      +/-   ##
==========================================
- Coverage   92.58%   90.34%   -2.24%     
==========================================
  Files          25       31       +6     
  Lines         364      487     +123     
==========================================
+ Hits          337      440     +103     
- Misses         27       47      +20
Impacted Files Coverage Δ
util/array.js 100% <ø> (ø)
domain/check-service.js 100% <ø> (ø)
domain/user.js 100% <ø> (ø)
util/date.js 100% <ø> (ø)
domain/daily-check-record.js 83.33% <ø> (ø)
domain/user-init-service.js 100% <ø> (ø)
domain/activity-service.js 83.33% <ø> (ø)
domain/activity.js 100% <ø> (ø)
domain/check-collection.js 100% <ø> (ø)
domain/button.js 100% <ø> (ø)
... and 33 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4d206c3...0e8e7a4. Read the comment docs.

@codecov
Copy link

codecov bot commented May 3, 2019

Codecov Report

Merging #31 into master will decrease coverage by 2.23%.
The diff coverage is 84.58%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #31      +/-   ##
==========================================
- Coverage   92.58%   90.34%   -2.24%     
==========================================
  Files          25       31       +6     
  Lines         364      487     +123     
==========================================
+ Hits          337      440     +103     
- Misses         27       47      +20
Impacted Files Coverage Δ
util/array.js 100% <ø> (ø)
domain/check-service.js 100% <ø> (ø)
domain/user.js 100% <ø> (ø)
util/date.js 100% <ø> (ø)
domain/daily-check-record.js 83.33% <ø> (ø)
domain/user-init-service.js 100% <ø> (ø)
domain/activity.js 100% <ø> (ø)
domain/check-collection.js 100% <ø> (ø)
domain/button.js 100% <ø> (ø)
domain/activity-repository.js 100% <ø> (ø)
... and 33 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aa33478...380ddd3. Read the comment docs.

@kt3k kt3k force-pushed the feature/now-2 branch 3 times, most recently from 6ac70dd to 6ae6e83 Compare May 3, 2019 04:07
@kt3k kt3k merged commit 5378309 into master May 3, 2019
@kt3k kt3k deleted the feature/now-2 branch May 3, 2019 04:31
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant