Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate to now 2 #31

Merged
merged 1 commit into from May 3, 2019

Conversation

Projects
None yet
1 participant
@kt3k
Copy link
Owner

commented May 3, 2019

Now 2 was released in Nov 2, 2018. It's a wrapper of AWS Lambda unlike Now 1. We're still able to use express.js in it by using @now/node-server builder. But I think that's not the way Now 2 recommend. So I separated endpoints into several small micro apps and made them into separate lambda endpoints.

@codecov

This comment has been minimized.

Copy link

commented May 3, 2019

Codecov Report

Merging #31 into master will decrease coverage by 2.23%.
The diff coverage is 84.58%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #31      +/-   ##
==========================================
- Coverage   92.58%   90.34%   -2.24%     
==========================================
  Files          25       31       +6     
  Lines         364      487     +123     
==========================================
+ Hits          337      440     +103     
- Misses         27       47      +20
Impacted Files Coverage Δ
util/array.js 100% <ø> (ø)
domain/check-service.js 100% <ø> (ø)
domain/user.js 100% <ø> (ø)
util/date.js 100% <ø> (ø)
domain/daily-check-record.js 83.33% <ø> (ø)
domain/user-init-service.js 100% <ø> (ø)
domain/activity-service.js 83.33% <ø> (ø)
domain/activity.js 100% <ø> (ø)
domain/check-collection.js 100% <ø> (ø)
domain/button.js 100% <ø> (ø)
... and 33 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 4d206c3...0e8e7a4. Read the comment docs.

@codecov

This comment has been minimized.

Copy link

commented May 3, 2019

Codecov Report

Merging #31 into master will decrease coverage by 2.23%.
The diff coverage is 84.58%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #31      +/-   ##
==========================================
- Coverage   92.58%   90.34%   -2.24%     
==========================================
  Files          25       31       +6     
  Lines         364      487     +123     
==========================================
+ Hits          337      440     +103     
- Misses         27       47      +20
Impacted Files Coverage Δ
util/array.js 100% <ø> (ø)
domain/check-service.js 100% <ø> (ø)
domain/user.js 100% <ø> (ø)
util/date.js 100% <ø> (ø)
domain/daily-check-record.js 83.33% <ø> (ø)
domain/user-init-service.js 100% <ø> (ø)
domain/activity.js 100% <ø> (ø)
domain/check-collection.js 100% <ø> (ø)
domain/button.js 100% <ø> (ø)
domain/activity-repository.js 100% <ø> (ø)
... and 33 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aa33478...380ddd3. Read the comment docs.

@kt3k kt3k force-pushed the feature/now-2 branch 3 times, most recently from 6ac70dd to 6ae6e83 May 3, 2019

@kt3k kt3k force-pushed the feature/now-2 branch from 6ae6e83 to 380ddd3 May 3, 2019

@kt3k kt3k merged commit 5378309 into master May 3, 2019

2 of 4 checks passed

codecov/patch 84.58% of diff hit (target 92.58%)
Details
codecov/project 90.34% (-2.24%) compared to aa33478
Details
ci/circleci: build Your tests passed on CircleCI!
Details
deploy/netlify Deploy preview ready!
Details

@kt3k kt3k deleted the feature/now-2 branch May 3, 2019

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.