Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: avoid to make input caret jump during editing declaration #16

Merged
merged 2 commits into from
Mar 21, 2018

Conversation

ktsn
Copy link
Owner

@ktsn ktsn commented Mar 21, 2018

In case if the users remove the part of declaration value, then it is trimmable like 10px 2 -> 10px , the caret will be jumped even though she is editing the value. It would decrease the UX of style editing.

This is caused because the current implementation always trims the updated text. So I've stopped trimming the value on input event. Instead, trim it when the input-end event so that the problem should not be occurred during user editing.

@codecov
Copy link

codecov bot commented Mar 21, 2018

Codecov Report

Merging #16 into master will decrease coverage by 0.09%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff            @@
##           master      #16     +/-   ##
=========================================
- Coverage   63.09%   62.99%   -0.1%     
=========================================
  Files          40       40             
  Lines        1306     1308      +2     
  Branches      313      323     +10     
=========================================
  Hits          824      824             
- Misses        467      469      +2     
  Partials       15       15
Impacted Files Coverage Δ
src/view/components/StyleInformation.vue 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 172a334...83f36ce. Read the comment docs.

@ktsn ktsn merged commit dd09ab6 into master Mar 21, 2018
@ktsn ktsn deleted the fix-cursor branch March 21, 2018 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant