Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow to update numeric style value by pressing up / down key #70

Merged
merged 6 commits into from
Nov 23, 2018

Conversation

ktsn
Copy link
Owner

@ktsn ktsn commented Nov 22, 2018

ref #13

This allows the users to update numeric style value by pressing up / down key just like Chrome dev tools.

I wrote very naive style value parser for that. And the range analyzation is quite naive also. But I find it just works in the case.

@ktsn ktsn mentioned this pull request Nov 22, 2018
6 tasks
@ktsn
Copy link
Owner Author

ktsn commented Nov 22, 2018

style-editing

@codecov
Copy link

codecov bot commented Nov 22, 2018

Codecov Report

Merging #70 into master will increase coverage by 0.45%.
The diff coverage is 72.61%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #70      +/-   ##
==========================================
+ Coverage   66.97%   67.42%   +0.45%     
==========================================
  Files          65       66       +1     
  Lines        2083     2229     +146     
  Branches      426      449      +23     
==========================================
+ Hits         1395     1503     +108     
- Misses        670      706      +36     
- Partials       18       20       +2
Impacted Files Coverage Δ
src/view/components/StyleDeclaration.vue 100% <ø> (ø) ⬆️
src/view/components/VueNode.vue 62.71% <ø> (ø) ⬆️
src/view/ui-logic/rendering.ts 98.74% <100%> (ø)
src/view/components/VueComponent.vue 91.3% <100%> (ø) ⬆️
src/view/components/VueSlot.vue 100% <100%> (ø) ⬆️
src/view/components/StyleValue.vue 43.85% <13.51%> (-56.15%) ⬇️
src/view/ui-logic/editing.ts 76.92% <76.92%> (ø)
src/view/ui-logic/style-value-lexer.ts 94.5% <94.5%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 487da34...aa699de. Read the comment docs.

@ktsn ktsn merged commit 2f33c62 into master Nov 23, 2018
@ktsn ktsn deleted the improve-style-editing branch November 23, 2018 15:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant