Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

zip_extract() returns 0 (OK) even if can't find ZIP #165

Closed
damian-m-g opened this issue Jan 1, 2021 · 2 comments
Closed

zip_extract() returns 0 (OK) even if can't find ZIP #165

damian-m-g opened this issue Jan 1, 2021 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@damian-m-g
Copy link

Hello kuba & collabs,

I use the return code of zip_extract() to find out if successfully extract files. When you pass a non-existent path to a zip, it will return 0 while it shouldn´t? Maybe I'm missing some thinking approach here, I'm basing on the zip_extract() documentation that says: 0 on success, negative number (< 0) on error.

image

From my point of view, it shouldn't return 0 if can't find the zip archive.

Cheers,

D.

@kuba-- kuba-- self-assigned this Jan 1, 2021
@kuba-- kuba-- added the bug Something isn't working label Jan 1, 2021
@kuba--
Copy link
Owner

kuba-- commented Jan 1, 2021

Thanks, it should be fixed by https://github.com/kuba--/zip/pull/166

@damian-m-g
Copy link
Author

The commit looks good. Thank you.

@kuba-- kuba-- closed this as completed Jan 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants