Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop \n\n as required separator for (full)chain certs #42

Closed
kuba opened this issue Dec 7, 2015 · 3 comments
Closed

Drop \n\n as required separator for (full)chain certs #42

kuba opened this issue Dec 7, 2015 · 3 comments

Comments

@kuba
Copy link
Owner

kuba commented Dec 7, 2015

This causes some troubles, e.g. when importing data from the official client. For more context see #40
@kuba kuba mentioned this issue Dec 7, 2015
Closed
@Lekensteyn
Copy link
Contributor

This will also affect external.sh and #33. Have their been deeper thoughts on this?

@Lekensteyn Lekensteyn mentioned this issue Dec 9, 2015
Closed
@kuba
Copy link
Owner Author

kuba commented Dec 12, 2015

Droping \n\n as required separtor should be backwards compatible, as we would just parse by detecing --- BEGIN --- and --- END --- separators. When I was quickly writing that code before launch, such implementation was just a lot harder than relying on split('\n\n'). I'm open for (RFC-compliant) PRs.

@kuba
Copy link
Owner Author

kuba commented Jan 7, 2016

This was fully fixed in c4f0cfd and is about to be merged with master.

@kuba kuba closed this as completed in c146947 Jan 7, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@kuba @Lekensteyn