Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[feature request] Delete the completed tfjob created by cron when tfjob number reach historyLimit #244

Open
heluocs opened this issue Mar 24, 2022 · 3 comments · May be fixed by #293
Open

[feature request] Delete the completed tfjob created by cron when tfjob number reach historyLimit #244

heluocs opened this issue Mar 24, 2022 · 3 comments · May be fixed by #293
Assignees
@jian-he
Labels
enhancement New feature or request

Comments

@heluocs
Copy link

heluocs commented Mar 24, 2022

What would you like to be added:

Cron support delete the completed tfjob when the tfjob number reach the historyLimit.

Why is this needed:

With the tfjob number in kubernetes cluster increased, the performance of training operator will decrease.
@SimonCqk
Copy link
Collaborator

@heluocs hi heluocs, it looks make sense, we'll implement it soon :)

@SimonCqk SimonCqk added the enhancement New feature or request label Mar 24, 2022
@sbdtu5498
Copy link
Contributor

/assign
@SimonCqk correct me if I am wrong. I checked the cron controller but this feature is not there yet. I will make a PR for this.

@SimonCqk
Copy link
Collaborator

well, it has not implemented yet, it looks good if you'd like to contribute!

@sbdtu5498 sbdtu5498 linked a pull request Apr 19, 2023 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jian-he jian-he

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Adding functionality to delete successfully completed jobs in a FIFO … sbdtu5498/kubedl
4 participants
@jian-he @heluocs @SimonCqk @sbdtu5498