Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

post: KF 1.5.1 release blog post #119

Merged
merged 8 commits into from
Aug 10, 2022
Merged

post: KF 1.5.1 release blog post #119

merged 8 commits into from
Aug 10, 2022

Conversation

kimwnasptd
Copy link
Member

@kimwnasptd
post: KF 1.5.1 release blog post
4793a8b 
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
@kimwnasptd
Copy link
Member Author

You can also take a peek of the current preview in https://deploy-preview-119--infallible-murdock-d05108.netlify.app/, from the above github checks

@jbottum
attempt to clean up "used by user applications"
68a0941 
I propose that used by user application is awkward.    I tried to re-write and retain the meaning.    Will this work ?
@jbottum
Copy link
Contributor

jbottum commented Jul 18, 2022

@surajkota Hey Suraj - Could you pleases review this PR and provide your comments and lgtm ?

@jbottum
Copy link
Contributor

jbottum commented Jul 18, 2022

@annajung would you please review this PR ?

@surajkota
Copy link

/approve

@surajkota surajkota mentioned this pull request Jul 18, 2022
Merged
kimwnasptd and others added 2 commits July 19, 2022 18:10
@kimwnasptd
review(anna): Remove extra spaces and correct link
7bd37f4 
Co-authored-by: Anna <antheaj@vmware.com>
@kimwnasptd
review(anna): nit
2915542 
Co-authored-by: Anna <antheaj@vmware.com>
@jbottum
Copy link
Contributor

jbottum commented Jul 22, 2022

@kimwnasptd line 17 probably need a period at the end of the sentence (after "here"). With that change, I provide

/lgtm

@google-oss-prow google-oss-prow bot added the lgtm label Jul 22, 2022
@kimwnasptd
review(zijianjoy): Make enables to unblocks
7f3be88 
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
@google-oss-prow google-oss-prow bot removed the lgtm label Jul 25, 2022
@annajung
Copy link
Member

/lgtm

@google-oss-prow google-oss-prow bot added the lgtm label Jul 25, 2022
@kimwnasptd
review(zijianjoy): Rephrase the enhancement part
8a0ab36 
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
@kimwnasptd
review(jbottum): Add a dot at the end
c89cbb3 
Signed-off-by: Kimonas Sotirchos <kimwnasptd@arrikto.com>
@google-oss-prow google-oss-prow bot removed the lgtm label Aug 1, 2022
@kimwnasptd
Copy link
Member Author

I've added the proposed changes from the comments above. I believe it should be ready to merge.

cc @zijianjoy @jbottum

@jbottum
Copy link
Contributor

jbottum commented Aug 1, 2022

@kimwnasptd I believe we need a "," after Mercedes Benz clusters, which I believe is on line 13. then its /lgtm

@zijianjoy
Copy link
Contributor

/lgtm
/approve

Thank you for composing the blog post!

@google-oss-prow google-oss-prow bot added the lgtm label Aug 2, 2022
@jbottum
Copy link
Contributor

jbottum commented Aug 4, 2022

/lgtm

@jbottum
Copy link
Contributor

jbottum commented Aug 4, 2022

@kimwnasptd can we please get this posted ?

@jbottum @droctothorpe
update adding ", the" before Mercedes Bend
48ae73f 
Co-authored-by: Alex <mythicalsunlight@gmail.com>
@google-oss-prow google-oss-prow bot removed the lgtm label Aug 10, 2022
@zijianjoy
Copy link
Contributor

@droctothorpe Would you like to sign the CLA to pass presubmit check?

@droctothorpe
Copy link
Contributor

Thanks, @zijianjoy. I've definitely signed the CLA. Investigating why it's not properly mapped to this commit now.

@droctothorpe
Copy link
Contributor

droctothorpe commented Aug 10, 2022 •
edited
Loading

Signed a new CLA with my mythicalsunlight@gmail.com gmail account. Not sure why this commit was flagged while others passed this gate without issue.

@droctothorpe
Copy link
Contributor

CLA check confirmed passing now.

@zijianjoy
Copy link
Contributor

/lgtm
/approve

@google-oss-prow google-oss-prow bot added the lgtm label Aug 10, 2022
@google-oss-prow
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by: kimwnasptd, shivaylamba, surajkota, yhwang, zijianjoy

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit b910c8d into kubeflow:master Aug 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@annajung annajung annajung left review comments

@droctothorpe droctothorpe droctothorpe left review comments

@zijianjoy zijianjoy zijianjoy left review comments

@yhwang yhwang yhwang approved these changes

@shivaylamba shivaylamba shivaylamba approved these changes

@surajkota surajkota surajkota approved these changes

@DomFleischmann DomFleischmann Awaiting requested review from DomFleischmann

@james-jwu james-jwu Awaiting requested review from james-jwu

@jbottum jbottum Awaiting requested review from jbottum

@theadactyl theadactyl Awaiting requested review from theadactyl

Assignees

@jbottum jbottum

@annajung annajung

@zijianjoy zijianjoy

Labels
approved lgtm size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@kimwnasptd @jbottum @surajkota @annajung @zijianjoy @droctothorpe @yhwang @shivaylamba