Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Xin(Henry) Wang from Arm to the contributors list #186

Merged
merged 1 commit into from
Nov 15, 2019
Merged

Add Xin(Henry) Wang from Arm to the contributors list #186

merged 1 commit into from
Nov 15, 2019

Conversation

MrXinWang
Copy link
Contributor

@MrXinWang MrXinWang commented Nov 1, 2019

@k8s-ci-robot
Copy link

Hi @MrXinWang. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@MrXinWang
Copy link
Contributor Author

MrXinWang commented Nov 13, 2019

/cc @jlewi @jinchihe

Referencing the comment in kubeflow/issue#2337 for multi-platform enablement of kubeflow, could you please add me to the contributors list so that I can join the kubeflow slack channel for further discussion with the community and the powerpc developers? Thank you very much!

@@ -240,6 +241,11 @@ orgs:
- ScorpioCPH
- ohmystack
privacy: closed
Arm:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We don't really use groups so unless you have a specific reason for adding a group please remove.

If you'd like Arm to be recognized as a contributor then please submit a PR adding it to
https://github.com/kubeflow/community/blob/master/member_organizations.yaml

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @jlewi ! Thanks for this, I have removed the addition for the group.

Thank you!

Signed-off-by: Henry Wang <henry.wang@arm.com>
@jlewi
Copy link
Contributor

jlewi commented Nov 15, 2019

/lgtm
/approve

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jlewi

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 8fcc246 into kubeflow:master Nov 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants