Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add support for aarch64 #1098

Merged
merged 1 commit into from
Nov 2, 2019
Merged

Add support for aarch64 #1098

merged 1 commit into from
Nov 2, 2019

Conversation

MrXinWang
Copy link
Contributor

@MrXinWang MrXinWang commented Nov 1, 2019 •
edited by jlewi

Signed-off-by: Henry Wang <henry.wang@arm.com>

This change is Reviewable

@MrXinWang
Add support for aarch64
2521555 
Change-Id: I5b80e63bde83ee0e203cdf4852bc44ec68059692
Signed-off-by: Henry Wang <henry.wang@arm.com>
Jira: ENTOS-1324
@k8s-ci-robot
Copy link

Hi @MrXinWang. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@coveralls
Copy link

Coverage Status

Coverage remained the same at 96.512% when pulling 2521555 on MrXinWang:arm64 into de4847c on kubeflow:master.

@TravisBuddy
Copy link

Hey @MrXinWang,
Your changes look good to me!

View build log

TravisBuddy Request Identifier: 96dcaf60-fc71-11e9-afa1-7d9fdd5cb875

gaocegege
gaocegege reviewed Nov 1, 2019
View reviewed changes
Copy link
Member

@gaocegege gaocegege left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm
/approve

@k8s-ci-robot
Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: gaocegege

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@gaocegege
Copy link
Member

/ok-to-test

@gaocegege
Copy link
Member

/retest

1 similar comment
@MrXinWang
Copy link
Contributor Author

/retest

@gaocegege
Copy link
Member

INFO:root:Type Reason Age From Message
INFO:root:---- ------ ---- ---- -------
INFO:root:Warning FailedScheduling 28s (x13 over 6m) default-scheduler no nodes available to schedule pods

@MrXinWang
Copy link
Contributor Author

MrXinWang commented Nov 1, 2019 •
edited

@gaocegege similar stuff also happened in pipelines#2507 and kfserving#507, any ideas?

Thanks!

@gaocegege
Copy link
Member

No idea about it. @johnugeorge @richardsliu Do you have experience on it?

This was referenced Nov 1, 2019
Merged
Merged
@MrXinWang
Copy link
Contributor Author

/retest

@k8s-ci-robot k8s-ci-robot merged commit ed85559 into kubeflow:master Nov 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gaocegege gaocegege gaocegege left review comments

@ChanYiLin ChanYiLin Awaiting requested review from ChanYiLin

@jimexist jimexist Awaiting requested review from jimexist

Assignees

@gaocegege gaocegege

Labels
approved lgtm ok-to-test size/XS
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@MrXinWang @k8s-ci-robot @coveralls @TravisBuddy @gaocegege