Add arm64 support for kfserving #507
Conversation
Change-Id: I8d583a60e3fc6f1714a75f8040164d4ed7a0d829 Signed-off-by: Henry Wang <henry.wang@arm.com> Jira: ENTOS-1325
|
Hi @MrXinWang. Thanks for your PR. I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
|
/ok-to-test |
|
Hi @jinchihe! I think something strange is going on with the CI? Any ideas? |
|
@MrXinWang That's should be caused by CI test env problem, I'm going to take a look. |
|
@jinchihe Thanks very much! |
|
Cool what's the scenario? Do istio and knative already work on arm? Also a lot more will be required including possibily selecting different base images.. can you raise an issue with details on the use case? /hold |
|
Hi @rakelkar! I think issue#2237 and this comment have something that you may be interested in. Basically we are trying to enable kubeflow on arm64 platform, and yes you are absolutely right that a lot more work is required. When I started to work on this project the latest version of kubeflow was 0.5.1, and istio was introduced in 0.6.0 and later. For now I am just contributing what I have achieved to upstream. We do have some discussions about the base image in kubeflow/pipeline PR#2507, maybe you can also share your opinion about it. Edited on 2, Nov: Also by asking some colleagues, I think istio supports arm64 now. |
|
/retest |
|
Test flake resolved in another PR. You may want to rebase. |
| @@ -9,6 +9,8 @@ COPY vendor/ vendor/ | |||
| # Build | |||
| RUN if [ "$(uname -m)" = "ppc64le" ]; then \ | |||
| CGO_ENABLED=0 GOOS=linux GOARCH=ppc64le go build -a -o manager ./cmd/manager; \ | |||
| elif [ "$(uname -m)" = "aarch64" ]; then \ | |||
| CGO_ENABLED=0 GOOS=linux GOARCH=arm64 go build -a -o manager ./cmd/manager; \ | |||
There was a problem hiding this comment.
make sense to just make this an envvar that gets picked up?
There was a problem hiding this comment.
Yes, it definately makes sense, however referencing moby/issue#29110 I don't think docker currently support the function that set ENV as the result of the shell command (in our case uname -m). I think this is also the reason why PowerPC guys keep the coding style of branch asif ["$(uname -m)" = ARCH] stuff.
There was a problem hiding this comment.
if we use RUN export MACHINE_ARCH=$(uname -m) && if [$MACHINE_ARCH="ppc64le"/"aarch64"/"x86_64"]; then blablabla, I think it is a little bit redundant isn't it?
|
Cool okay - will be awesome to see it work on arm64. If you are trying to minimize initial scope you dont need the executor as it is not currently used. /hold cancel |
|
@jinchihe Test works perfectly now, thanks |
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: animeshsingh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Change-Id: I8d583a60e3fc6f1714a75f8040164d4ed7a0d829 Signed-off-by: Henry Wang <henry.wang@arm.com> Jira: ENTOS-1325
…erve-agent-hermetic-poc Red Hat Konflux update kserve-agent-hermetic-poc
Signed-off-by: Henry Wang <henry.wang@arm.com>
This change is