Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/Example for training KFP v1 #2118

Closed
wants to merge 26 commits into from

Commits on Jul 18, 2023

  1. Adds a first draft of a kfpv1-metricscollector

    Closesly modelled after the tfevent-metricscollector.
    Currently not yet working, as there are issues
    that the arguments from the `injector_webhoook`
    are somehow not passed.
    
    Addresses: kubeflow#2019
    votti committed Jul 18, 2023
    Configuration menu
    Copy the full SHA
    03fa850 View commit details
    Browse the repository at this point in the history
  2. Use PodName as input

    The TrialName can be parse from the pod name.
    
    This seems currently a good way to get the trial name. For
    more discussion see: kubeflow#2109
    votti authored and Vito Zanotelli committed Jul 18, 2023
    Configuration menu
    Copy the full SHA
    8918473 View commit details
    Browse the repository at this point in the history
  3. Adds example for tuning a kfp v1 pipeline with Katib

    This example illustrates how a full kfp pipeline can
    be tuned using Katib.
    
    It is based on a metrics collector to collect kubeflow
    pipeline metrics (kubeflow#2019). This is used as a Custom Collector.
    
    Addresses: kubeflow#1914, kubeflow#2019
    votti authored and Vito Zanotelli committed Jul 18, 2023
    Configuration menu
    Copy the full SHA
    fd53d85 View commit details
    Browse the repository at this point in the history
  4. Adds python < 3.11 compatiblity

    Before the notebook only worked with Python 3.11.
    Now it is also tested with 3.10
    
    Also the experiment/run name is extended with a timestamp
    for easier reruns.
    votti authored and Vito Zanotelli committed Jul 18, 2023
    Configuration menu
    Copy the full SHA
    e9a0051 View commit details
    Browse the repository at this point in the history
  5. Add histogram equalization before rescaling

    Otherwise the image was binarized, leading to an
    artifically bad performance.
    votti authored and Vito Zanotelli committed Jul 18, 2023
    Configuration menu
    Copy the full SHA
    17123d6 View commit details
    Browse the repository at this point in the history
  6. Update copyright date

    And remove an old comment
    votti authored and Vito Zanotelli committed Jul 18, 2023
    Configuration menu
    Copy the full SHA
    4f19db8 View commit details
    Browse the repository at this point in the history
  7. Update python version

    votti authored and Vito Zanotelli committed Jul 18, 2023
    Configuration menu
    Copy the full SHA
    9f83b0f View commit details
    Browse the repository at this point in the history
  8. Publish the docker image in kubeflowkatib

    votti authored and Vito Zanotelli committed Jul 18, 2023
    Configuration menu
    Copy the full SHA
    61e77ea View commit details
    Browse the repository at this point in the history
  9. Fix suggested typo fixes

    Co-authored-by: axel7083 <42176370+axel7083@users.noreply.github.com>
    2 people authored and Vito Zanotelli committed Jul 18, 2023
    Configuration menu
    Copy the full SHA
    88c20c3 View commit details
    Browse the repository at this point in the history
  10. Move KFP V1 metrics collector docker files to v1 subfolder

    As per suggestion
    votti authored and Vito Zanotelli committed Jul 18, 2023
    Configuration menu
    Copy the full SHA
    904d07d View commit details
    Browse the repository at this point in the history
  11. Support loading of folder of metrics collector files

    As suggested in the PR review, the generic case where multiple KFP pipeline
    metrics files would be present in the output folder is supported.
    
    Note that in the current KFP v1 implementation always only one data
    file is present.
    votti authored and Vito Zanotelli committed Jul 18, 2023
    Configuration menu
    Copy the full SHA
    31655dd View commit details
    Browse the repository at this point in the history
  12. Move kfpv1 metricscollector in v1 subfolder

    As per suggestion this should make it easier to handle the v2 metrics
    collector in the future as well
    votti authored and Vito Zanotelli committed Jul 18, 2023
    Configuration menu
    Copy the full SHA
    c458541 View commit details
    Browse the repository at this point in the history
  13. Remove duplicated notebook section

    votti authored and Vito Zanotelli committed Jul 18, 2023
    Configuration menu
    Copy the full SHA
    cee9970 View commit details
    Browse the repository at this point in the history
  14. Add dependencies for KFPv1 e2e testing

    This installs Kubeflow pipelines (KFP) if selected to do so in order to
    run e2e tests where Katib and KFP interact.
    Vito Zanotelli committed Jul 18, 2023
    Configuration menu
    Copy the full SHA
    f7e697b View commit details
    Browse the repository at this point in the history
  15. TMP: changes to run tests locally

    This commit should be removed later
    Vito Zanotelli committed Jul 18, 2023
    Configuration menu
    Copy the full SHA
    36ed372 View commit details
    Browse the repository at this point in the history
  16. Add missing ClusterRole update

    These permissions are required such that the katib-controller can launch
    argo workflows.
    Vito Zanotelli committed Jul 18, 2023
    Configuration menu
    Copy the full SHA
    15c4a4b View commit details
    Browse the repository at this point in the history
  17. Remove accidentally included self

    Vito Zanotelli committed Jul 18, 2023
    Configuration menu
    Copy the full SHA
    741059f View commit details
    Browse the repository at this point in the history
  18. Rename paramater to more meaningful name

    Vito Zanotelli committed Jul 18, 2023
    Configuration menu
    Copy the full SHA
    7d33b7b View commit details
    Browse the repository at this point in the history

Commits on Jul 20, 2023

  1. Extend example notebook with simple example for e2e tests

    This adds a dummy e2e example that can be used to test the main
    functionality.
    Vito Zanotelli committed Jul 20, 2023
    Configuration menu
    Copy the full SHA
    35df815 View commit details
    Browse the repository at this point in the history
  2. Revert "TMP: changes to run tests locally"

    This reverts commit 36ed372.
    Vito Zanotelli committed Jul 20, 2023
    Configuration menu
    Copy the full SHA
    0504085 View commit details
    Browse the repository at this point in the history
  3. Adds spec of a simple kfp1+katib experiment spec

    This could be used for e2e testing
    Vito Zanotelli committed Jul 20, 2023
    Configuration menu
    Copy the full SHA
    4cddd3e View commit details
    Browse the repository at this point in the history

Commits on Jul 21, 2023

  1. Update psutil version to fix Docker build error

    Vito Zanotelli committed Jul 21, 2023
    Configuration menu
    Copy the full SHA
    6a0bdd3 View commit details
    Browse the repository at this point in the history

Commits on Sep 12, 2023

  1. Move kubeflow installation after katib

    Otherwise the patching of the `katib-controller` cluster role would
    not work.
    pre-commit fix Vito Zanotelli committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    182b787 View commit details
    Browse the repository at this point in the history
  2. Parametrize kubeflow version

    This enables the user to set th version of the KFP
    version which should be useful to use this script
    to install KFP v1 and v2 without additional parameters.
    pre-commit fix Vito Zanotelli committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    9fc7c02 View commit details
    Browse the repository at this point in the history
  3. Add namespace parameter

    This is required for kubeflow pipelines as I found no easy way
    to install kubeflow pipelines into the `default` workspace
    that was previously the hardcoded one.
    
    Now the namespace can be passed as a parameter.
    pre-commit fix Vito Zanotelli committed Sep 12, 2023
    Configuration menu
    Copy the full SHA
    579546c View commit details
    Browse the repository at this point in the history

Commits on Oct 21, 2023

  1. Add kfpv1 e2e test

    This action should now run the kubeflow pipeline v1 e2e example.
    
    This required the extension of the `template-e2e-test` to include
    parameters to
    a) install kfp
    b) select the `kubeflow` namespace (instead of default) to run the tests
    with.
    pre-commit fix Vito Zanotelli committed Oct 21, 2023
    Configuration menu
    Copy the full SHA
    582a6a7 View commit details
    Browse the repository at this point in the history