Add volumeop and volumesnapshot support #93
Conversation
|
This change is |
|
Vincent updated the resourceop task, so i will update the volumeop with the corresponding changes soon. |
|
FYI, don't test with the default image yet because there's a small bug in the wrapper code. Will unhold this once the image is updated. |
|
/unhold |
|
/assign @fenglixa |
| SUCCESS: volumeop_basic.py | ||
| SUCCESS: volumeop_dag.py | ||
| SUCCESS: volumeop_parallel.py | ||
| SUCCESS: volumeop_sequential.py |
There was a problem hiding this comment.
Just a question here, does all these volumeop works now?
There was a problem hiding this comment.
These pipelines should work as long as your default storageclass support readwritemany.
There was a problem hiding this comment.
I tested the basic and parallel one on my cluster and they are running as expected.
| success_condition = op.resource.get('success_condition') | ||
| failure_condition = op.resource.get('failure_condition') | ||
| success_condition = op.resource.get('successCondition') | ||
| failure_condition = op.resource.get('failureCondition') |
|
Thanks @Tomcli |
|
/assign @animeshsingh @ckadner |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: animeshsingh The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Add namespace and DSPA name in Reconciler logs
Which issue is resolved by this Pull Request:
Resolves #51 and resolves #86
Description of your changes:
Add volumeop support with some workaround on the unsupported Argo variables and extend task outputs using an extra step. Ideally we should improve the wrapper with multiple outputs. I will create an issue for the wrapper issue so we can improve it in the future.Update resourceOp with vincent's latest changes to support volumeop and volumesnapshotop.
Environment tested:
python --version): 3.6.4tkn version): 0.11kubectl version): 1.15/etc/os-release):