Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend resourceOp warpper image to operate the list of resources #121

Closed
fenglixa opened this issue Apr 27, 2020 · 8 comments
Closed

Extend resourceOp warpper image to operate the list of resources #121

fenglixa opened this issue Apr 27, 2020 · 8 comments

Comments

@fenglixa
Copy link
Member

fenglixa commented Apr 27, 2020

/kind feature

Description:
[A clear and concise description of what your proposal. What problem does it solve?]
As discussion in the ticket #70 and #82. Tekton has been explicitly avoiding adding support for recursion and dynamic behavior. So we have to find another way for the solutions.

ResourceOps and VolumeOps are supported in kfp-tekton right now, by PR #89 , #93 and kubectl-wrapper from @vincent-pli .

Another solution we can extend resourceOp warpper image to have additional parmeter (could be named as "parallel-loop-items") with the value of the list, support the type of [a, b, c, d] and also [{'a': 1, 'b': 2}, {'a': 10, 'b': 20}], apply each value of the list to manifest to support this feature.

Additional information:
[Miscellaneous information that will assist in solving the issue.]

@issue-label-bot
Copy link

Issue-Label Bot is automatically applying the labels:

Label Probability
kind/feature 0.95

Please mark this comment with 👍 or 👎 to give our bot feedback!
Links: app homepage, dashboard and code for this bot.

@fenglixa fenglixa changed the title Extend resourceOp warpper image to have additional parmeter with the value of a list, and apply it to manifest Extend resourceOp warpper image to have additional parmeter with the list value Apr 27, 2020
@fenglixa fenglixa changed the title Extend resourceOp warpper image to have additional parmeter with the list value Extend resourceOp warpper image to operate the list of resources Apr 27, 2020
@fenglixa
Copy link
Member Author

@vincent-pli @Tomcli any comments?

@Tomcli
Copy link
Member

Tomcli commented Apr 30, 2020

Hi @fenglixa, here is the tracking issue in the Tekton community tektoncd/pipeline#2050

They have been discussing what are the cases they need to cover for the looping support such as looping with conditions, parallel vs sequential loop, etc. Adding all these use cases will be hard for the wrapper image and we won't get the logging and visual support from Tekton.

@fenglixa
Copy link
Member Author

fenglixa commented May 1, 2020

Thanks @Tomcli , It's great if tekton could support the looping parms. That's should be the final solution.
@vincent-pli, FYI. Thanks for your support!

@vincent-pli
Copy link
Contributor

@Tomcli @fenglixa That great to hear that, thanks.

@Tomcli
Copy link
Member

Tomcli commented Sep 9, 2020

/close
will wait for tekton loop support

@k8s-ci-robot
Copy link

@Tomcli: Closing this issue.

In response to this:

/close
will wait for tekton loop support

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@issue-label-bot
Copy link

Issue-Label Bot is automatically applying the labels:

Label Probability
area/engprod 0.54

Please mark this comment with 👍 or 👎 to give our bot feedback!
Links: app homepage, dashboard and code for this bot.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants