Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TfJob controllers are not namespace scoped so tests aren't isolated #134

Closed
jlewi opened this issue Jan 18, 2018 · 3 comments
Closed

TfJob controllers are not namespace scoped so tests aren't isolated #134

jlewi opened this issue Jan 18, 2018 · 3 comments
Labels
area/testing area/0.2.0 priority/p1

Comments

@jlewi
Copy link
Contributor

jlewi commented Jan 18, 2018

Controller claims jobs in all namespaces, but our tests are trying to reuse clusters by deploying in different namespaces.

So our tests aren't isolated.

Possible fixes

  1. Run each E2E test in a separate cluster
  2. Run add options to controller so it only claims jobs in a given namespace.
@jlewi
Copy link
Contributor Author

jlewi commented Apr 10, 2018

I suspect this might be causing TFJob test flakes where we see simple job test occasionally timing out waiting for a TFJob to finish. See for example #602

@jlewi jlewi mentioned this issue Apr 10, 2018
Closed
@jlewi
Copy link
Contributor Author

jlewi commented Jun 5, 2018

@ankushagarwal This is fixed by #894 correct?

@ankushagarwal
Copy link
Contributor

Yes.

@jlewi jlewi mentioned this issue Oct 25, 2018
Closed
yanniszark pushed a commit to arrikto/kubeflow that referenced this issue Nov 1, 2019
@zabbasi @k8s-ci-robot
Remove admission-webhook/bootstrap hard-coded selector (kubeflow#134)
fea53c8 
* remove the hard-coded selector

* run make generate and make test
yanniszark pushed a commit to arrikto/kubeflow that referenced this issue Nov 1, 2019
@richardsliu @k8s-ci-robot
Partial Revert "Remove admission-webhook/bootstrap hard-coded selecto…
d0d71f6 
…r" (kubeflow#150)

* Revert "Remove admission-webhook/bootstrap hard-coded selector (kubeflow#134)"

This reverts commit fea53c8.

* Update stateful-set.yaml

* Update bootstrap-base_test.go

* Fix build

* Revert "Remove admission-webhook/bootstrap hard-coded selector (kubeflow#134)"

This reverts commit fea53c8.

Update stateful-set.yaml

Update bootstrap-base_test.go

Fix build
elenzio9 pushed a commit to arrikto/kubeflow that referenced this issue Oct 31, 2022
@dushyanthsc @k8s-ci-robot
Adding dushyanthsc to the member list (kubeflow#134)
9c8b4c0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/testing area/0.2.0 priority/p1
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jlewi @ankushagarwal