Partial Revert "Remove admission-webhook/bootstrap hard-coded selecto…

…r" (kubeflow#150) * Revert "Remove admission-webhook/bootstrap hard-coded selector (kubeflow#134)" This reverts commit fea53c8. * Update stateful-set.yaml * Update bootstrap-base_test.go * Fix build * Revert "Remove admission-webhook/bootstrap hard-coded selector (kubeflow#134)" This reverts commit fea53c8. Update stateful-set.yaml Update bootstrap-base_test.go Fix build
arrikto · Jun 19, 2019 · d0d71f6 · d0d71f6
1 parent 515c154
commit d0d71f6
Show file tree

Hide file tree

Showing 7 changed files with 35 additions and 35 deletions.
diff --git a/tests/metrics-collector-base_test.go → ...b-v1alpha1-metrics-collector-base_test.go b/tests/metrics-collector-base_test.go → ...b-v1alpha1-metrics-collector-base_test.go
@@ -11,7 +11,7 @@ import (
 	"testing"
 )
 
-func writeMetricsCollectorBase(th *KustTestHarness) {
+func writeKatibV1Alpha1MetricsCollectorBase(th *KustTestHarness) {
 	th.writeF("/manifests/katib-v1alpha1/metrics-collector/base/metrics-collector-rbac.yaml", `
 kind: ClusterRole
 apiVersion: rbac.authorization.k8s.io/v1
@@ -104,9 +104,9 @@ images:
 `)
 }
 
-func TestMetricsCollectorBase(t *testing.T) {
+func TestKatibV1Alpha1MetricsCollectorBase(t *testing.T) {
 	th := NewKustTestHarness(t, "/manifests/katib-v1alpha1/metrics-collector/base")
-	writeMetricsCollectorBase(th)
+	writeKatibV1Alpha1MetricsCollectorBase(th)
 	m, err := th.makeKustTarget().MakeCustomizedResMap()
 	if err != nil {
 		t.Fatalf("Err: %v", err)

diff --git a/tests/studyjob-base_test.go → tests/katib-v1alpha1-studyjob-base_test.go b/tests/studyjob-base_test.go → tests/katib-v1alpha1-studyjob-base_test.go
@@ -11,7 +11,7 @@ import (
 	"testing"
 )
 
-func writeStudyjobBase(th *KustTestHarness) {
+func writeKatibV1Alpha1StudyJobBase(th *KustTestHarness) {
 	th.writeF("/manifests/katib-v1alpha1/studyjob/base/studyjob-controller-deployment.yaml", `
 apiVersion: extensions/v1beta1
 kind: Deployment
@@ -187,9 +187,9 @@ images:
 `)
 }
 
-func TestStudyjobBase(t *testing.T) {
+func TestKatibV1Alpha1StudyJobBase(t *testing.T) {
 	th := NewKustTestHarness(t, "/manifests/katib-v1alpha1/studyjob/base")
-	writeStudyjobBase(th)
+	writeKatibV1Alpha1StudyJobBase(th)
 	m, err := th.makeKustTarget().MakeCustomizedResMap()
 	if err != nil {
 		t.Fatalf("Err: %v", err)

diff --git a/tests/suggestion-base_test.go → tests/katib-v1alpha1-suggestion-base_test.go b/tests/suggestion-base_test.go → tests/katib-v1alpha1-suggestion-base_test.go
@@ -11,7 +11,7 @@ import (
 	"testing"
 )
 
-func writeSuggestionBase(th *KustTestHarness) {
+func writeKatibV1Alpha1Suggestion(th *KustTestHarness) {
 	th.writeF("/manifests/katib-v1alpha1/suggestion/base/suggestion-bayesianoptimization-deployment.yaml", `
 apiVersion: extensions/v1beta1
 kind: Deployment
@@ -231,9 +231,9 @@ images:
 `)
 }
 
-func TestSuggestionBase(t *testing.T) {
+func TestKatibV1Alpha1Suggestion(t *testing.T) {
 	th := NewKustTestHarness(t, "/manifests/katib-v1alpha1/suggestion/base")
-	writeSuggestionBase(th)
+	writeKatibV1Alpha1Suggestion(th)
 	m, err := th.makeKustTarget().MakeCustomizedResMap()
 	if err != nil {
 		t.Fatalf("Err: %v", err)

diff --git a/tests/katib-ui-base_test.go → tests/katib-v1alpha1-ui-base_test.go b/tests/katib-ui-base_test.go → tests/katib-v1alpha1-ui-base_test.go
@@ -11,7 +11,7 @@ import (
 	"testing"
 )
 
-func writeKatibUiBase(th *KustTestHarness) {
+func writeKatibV1Alpha1UIBase(th *KustTestHarness) {
 	th.writeF("/manifests/katib-v1alpha1/katib-ui/base/katib-ui-deployment.yaml", `
 apiVersion: extensions/v1beta1
 kind: Deployment
@@ -124,9 +124,9 @@ vars:
 `)
 }
 
-func TestKatibUiBase(t *testing.T) {
+func TestKatibV1Alpha1UIBase(t *testing.T) {
 	th := NewKustTestHarness(t, "/manifests/katib-v1alpha1/katib-ui/base")
-	writeKatibUiBase(th)
+	writeKatibV1Alpha1UIBase(th)
 	m, err := th.makeKustTarget().MakeCustomizedResMap()
 	if err != nil {
 		t.Fatalf("Err: %v", err)

diff --git a/tests/katib-ui-overlays-istio_test.go → .../katib-v1alpha1-ui-overlays-istio_test.go b/tests/katib-ui-overlays-istio_test.go → .../katib-v1alpha1-ui-overlays-istio_test.go
@@ -11,7 +11,7 @@ import (
 	"testing"
 )
 
-func writeKatibUiOverlaysIstio(th *KustTestHarness) {
+func writeKatibV1Alpha1UIOverlaysIstio(th *KustTestHarness) {
 	th.writeF("/manifests/katib-v1alpha1/katib-ui/overlays/istio/katib-ui-virtual-service.yaml", `
 apiVersion: networking.istio.io/v1alpha3
 kind: VirtualService
@@ -161,14 +161,14 @@ vars:
 `)
 }
 
-func TestKatibUiOverlaysIstio(t *testing.T) {
-	th := NewKustTestHarness(t, "/manifests/katib-v1alpha1/katib-ui/overlays/istio")
-	writeKatibUiOverlaysIstio(th)
+func TestKatibV1Alpha1UIOverlaysIstio(t *testing.T) {
+	th := NewKustTestHarness(t, "/manifests/katib-v1alpha1/katib-ui/base")
+	writeKatibV1Alpha1UIOverlaysIstio(th)
 	m, err := th.makeKustTarget().MakeCustomizedResMap()
 	if err != nil {
 		t.Fatalf("Err: %v", err)
 	}
-	targetPath := "../katib-v1alpha1/katib-ui/overlays/istio"
+	targetPath := "../katib-v1alpha1/katib-ui/base"
 	fsys := fs.MakeRealFS()
 	_loader, loaderErr := loader.NewLoader(targetPath, fsys)
 	if loaderErr != nil {

diff --git a/tests/vizier-core-base_test.go → ...s/katib-v1alpha1-vizier-core-base_test.go b/tests/vizier-core-base_test.go → ...s/katib-v1alpha1-vizier-core-base_test.go
@@ -11,7 +11,7 @@ import (
 	"testing"
 )
 
-func writeVizierCoreBase(th *KustTestHarness) {
+func writeKatibV1Alpha1VizierCore(th *KustTestHarness) {
 	th.writeF("/manifests/katib-v1alpha1/vizier-core/base/vizier-core-deployment.yaml", `
 apiVersion: extensions/v1beta1
 kind: Deployment
@@ -162,9 +162,9 @@ images:
 `)
 }
 
-func TestVizierCoreBase(t *testing.T) {
+func TestKatibV1Alpha1VizierCore(t *testing.T) {
 	th := NewKustTestHarness(t, "/manifests/katib-v1alpha1/vizier-core/base")
-	writeVizierCoreBase(th)
+	writeKatibV1Alpha1VizierCore(th)
 	m, err := th.makeKustTarget().MakeCustomizedResMap()
 	if err != nil {
 		t.Fatalf("Err: %v", err)

diff --git a/tests/vizier-db-base_test.go → tests/katib-v1alpha1-vizier-db-base_test.go b/tests/vizier-db-base_test.go → tests/katib-v1alpha1-vizier-db-base_test.go
@@ -11,7 +11,19 @@ import (
 	"testing"
 )
 
-func writeVizierDbBase(th *KustTestHarness) {
+func writeKatibV1Alpha1VizierDbBase(th *KustTestHarness) {
+	th.writeF("/manifests/katib-v1alpha1/vizier-db/base/vizier-db-pvc.yaml", `
+apiVersion: v1
+kind: PersistentVolumeClaim
+metadata:
+  name: katib-mysql
+spec:
+  accessModes:
+    - ReadWriteOnce
+  resources:
+    requests:
+      storage: 10Gi
+`)
 	th.writeF("/manifests/katib-v1alpha1/vizier-db/base/vizier-db-deployment.yaml", `
 apiVersion: extensions/v1beta1
 kind: Deployment
@@ -62,18 +74,6 @@ spec:
       - name: katib-mysql
         persistentVolumeClaim:
           claimName: katib-mysql
-`)
-	th.writeF("/manifests/katib-v1alpha1/vizier-db/base/vizier-db-pvc.yaml", `
-apiVersion: v1
-kind: PersistentVolumeClaim
-metadata:
-  name: katib-mysql
-spec:
-  accessModes:
-    - ReadWriteOnce
-  resources:
-    requests:
-      storage: 10Gi
 `)
 	th.writeF("/manifests/katib-v1alpha1/vizier-db/base/vizier-db-secret.yaml", `
 apiVersion: v1
@@ -115,9 +115,9 @@ images:
 `)
 }
 
-func TestVizierDbBase(t *testing.T) {
+func TestKatibV1Alpha1VizierDbBase(t *testing.T) {
 	th := NewKustTestHarness(t, "/manifests/katib-v1alpha1/vizier-db/base")
-	writeVizierDbBase(th)
+	writeKatibV1Alpha1VizierDbBase(th)
 	m, err := th.makeKustTarget().MakeCustomizedResMap()
 	if err != nil {
 		t.Fatalf("Err: %v", err)