Sorting support for VWA and TWA #6743
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Enable sorting functionality in VWA. Signed-off-by: Elena Zioga <elena@arrikto.com>
* Enable sorting functionality in TWA. Signed-off-by: Elena Zioga <elena@arrikto.com>
* Fix unit tests. Signed-off-by: Elena Zioga <elena@arrikto.com>
elenzio9
force-pushed
the
feature-elena-wa-support-sorting-1
branch
from
2c0c600
to
f9761d5
Compare
|
/area jupyter |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kimwnasptd The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
maroroman
pushed a commit
to maroroman/kubeflow
that referenced
this pull request
Feb 7, 2023
* vwa(front): Enable sorting in VWA (kubeflow#6460) * Enable sorting functionality in VWA. Signed-off-by: Elena Zioga <elena@arrikto.com> * twa(front): Enable sorting in TWA (kubeflow#6460) * Enable sorting functionality in TWA. Signed-off-by: Elena Zioga <elena@arrikto.com> * web-apps(front): Fix unit tests * Fix unit tests. Signed-off-by: Elena Zioga <elena@arrikto.com> Signed-off-by: Elena Zioga <elena@arrikto.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR enables sorting for VWA and TWA as part of #6460.
Related PR: #6742