Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Sorting support for the web apps #6460

Open
kimwnasptd opened this issue May 1, 2022 · 1 comment
Open

Sorting support for the web apps #6460

kimwnasptd opened this issue May 1, 2022 · 1 comment
Labels
area/jupyter Issues related to Jupyter kind/feature priority/p1

Comments

@kimwnasptd
Copy link
Member

/kind feature

Why you need this feature:
In KF 1.5 we introduced some basic frontend side pagination in #6316. This means that users will no longer see all the Notebooks at once.

We'll need to improve the UX of how people can find their K8s objects faster. A first step for this can be sorting

Describe the solution you'd like:
Right now the apps are polling the backend and are fetching for the full list of objects. This means that the frontend always has the full list available. We should also mention that an orthogonal effort here is to make this more efficient, to reduce the load of constantly polling #5201 #6454

For a first iteration we can do all the sorting in the frontend, since we have the data readily available there

Anything else you would like to add:
@elenzio9 and I have started working on this, for which we should be able to send a PR very soon
@kubeflow-bot kubeflow-bot added this to To Do in Needs Triage May 1, 2022
@kimwnasptd kimwnasptd mentioned this issue May 1, 2022
Closed
@jbottum jbottum mentioned this issue May 10, 2022
Merged
@kimwnasptd kimwnasptd mentioned this issue Oct 13, 2022
Closed
@elenzio9 elenzio9 mentioned this issue Nov 3, 2022
Merged
@jbottum
Copy link
Contributor

jbottum commented Nov 11, 2022

/priority P1
/area Jupyter

@google-oss-prow google-oss-prow bot added priority/p1 area/jupyter Issues related to Jupyter labels Nov 11, 2022
@kubeflow-bot kubeflow-bot removed this from To Do in Needs Triage Nov 11, 2022
elenzio9 added a commit to arrikto/kubeflow that referenced this issue Nov 15, 2022
@elenzio9
web-apps(front): Add sorting in common code (kubeflow#6460)
f59ce80 
* Add sorting functionality in the common code.

Signed-off-by: Elena Zioga <elena@arrikto.com>
elenzio9 added a commit to arrikto/kubeflow that referenced this issue Nov 15, 2022
@elenzio9
jwa(front): Enable sorting in JWA (kubeflow#6460)
06eee57 
* Enable sorting functionality in JWA.

Signed-off-by: Elena Zioga <elena@arrikto.com>
@elenzio9 elenzio9 mentioned this issue Nov 15, 2022
Merged
elenzio9 added a commit to arrikto/kubeflow that referenced this issue Nov 15, 2022
@elenzio9
web-apps(front): Add sorting in common code (kubeflow#6460)
b07a34a 
* Add sorting functionality in the common code.

Signed-off-by: Elena Zioga <elena@arrikto.com>
elenzio9 added a commit to arrikto/kubeflow that referenced this issue Nov 15, 2022
@elenzio9
jwa(front): Enable sorting in JWA (kubeflow#6460)
0f49500 
* Enable sorting functionality in JWA.

Signed-off-by: Elena Zioga <elena@arrikto.com>
elenzio9 added a commit to arrikto/kubeflow that referenced this issue Nov 15, 2022
@elenzio9
web-apps(front): Add sorting in common code (kubeflow#6460)
51d9ddf 
* Add sorting functionality in the common code.

Signed-off-by: Elena Zioga <elena@arrikto.com>
elenzio9 added a commit to arrikto/kubeflow that referenced this issue Nov 15, 2022
@elenzio9
jwa(front): Enable sorting in JWA (kubeflow#6460)
640dd1d 
* Enable sorting functionality in JWA.

Signed-off-by: Elena Zioga <elena@arrikto.com>
elenzio9 added a commit to arrikto/kubeflow that referenced this issue Nov 15, 2022
@elenzio9
vwa(front): Enable sorting in VWA (kubeflow#6460)
b447708 
* Enable sorting functionality in VWA.

Signed-off-by: Elena Zioga <elena@arrikto.com>
elenzio9 added a commit to arrikto/kubeflow that referenced this issue Nov 15, 2022
@elenzio9
twa(front): Enable sorting in TWA (kubeflow#6460)
2c0c600 
* Enable sorting functionality in TWA.

Signed-off-by: Elena Zioga <elena@arrikto.com>
@elenzio9 elenzio9 mentioned this issue Nov 15, 2022
Merged
elenzio9 added a commit to arrikto/kubeflow that referenced this issue Nov 15, 2022
@elenzio9
web-apps(front): Create unit tests for sorting (kubeflow#6460)
88aeefd 
* Create unit tests for the sorting functionality.

Signed-off-by: Elena Zioga <elena@arrikto.com>
@elenzio9 elenzio9 mentioned this issue Nov 15, 2022
Merged
google-oss-prow bot pushed a commit that referenced this issue Nov 15, 2022
@elenzio9
Sorting support for JWA (#6742)
0ddc032 
* web-apps(front): Add sorting in common code (#6460)

* Add sorting functionality in the common code.

Signed-off-by: Elena Zioga <elena@arrikto.com>

* jwa(front): Enable sorting in JWA (#6460)

* Enable sorting functionality in JWA.

Signed-off-by: Elena Zioga <elena@arrikto.com>

Signed-off-by: Elena Zioga <elena@arrikto.com>
elenzio9 added a commit to arrikto/kubeflow that referenced this issue Nov 15, 2022
@elenzio9
vwa(front): Enable sorting in VWA (kubeflow#6460)
d9bdad0 
* Enable sorting functionality in VWA.

Signed-off-by: Elena Zioga <elena@arrikto.com>
elenzio9 added a commit to arrikto/kubeflow that referenced this issue Nov 15, 2022
@elenzio9
twa(front): Enable sorting in TWA (kubeflow#6460)
a8bdc76 
* Enable sorting functionality in TWA.

Signed-off-by: Elena Zioga <elena@arrikto.com>
google-oss-prow bot pushed a commit that referenced this issue Nov 16, 2022
@elenzio9
Sorting support for VWA and TWA (#6743)
cc6e0b1 
* vwa(front): Enable sorting in VWA (#6460)

* Enable sorting functionality in VWA.

Signed-off-by: Elena Zioga <elena@arrikto.com>

* twa(front): Enable sorting in TWA (#6460)

* Enable sorting functionality in TWA.

Signed-off-by: Elena Zioga <elena@arrikto.com>

* web-apps(front): Fix unit tests

* Fix unit tests.

Signed-off-by: Elena Zioga <elena@arrikto.com>

Signed-off-by: Elena Zioga <elena@arrikto.com>
elenzio9 added a commit to arrikto/kubeflow that referenced this issue Nov 23, 2022
@elenzio9
web-apps(front): Enable sorting in namespace column (kubeflow#6460)
8b16bca 
Enable sorting in namespace column.

Signed-off-by: Elena Zioga <elena@arrikto.com>
@elenzio9 elenzio9 mentioned this issue Nov 23, 2022
Merged
maroroman pushed a commit to maroroman/kubeflow that referenced this issue Feb 7, 2023
@elenzio9 @maroroman
Sorting support for JWA (kubeflow#6742)
bf310ee 
* web-apps(front): Add sorting in common code (kubeflow#6460)

* Add sorting functionality in the common code.

Signed-off-by: Elena Zioga <elena@arrikto.com>

* jwa(front): Enable sorting in JWA (kubeflow#6460)

* Enable sorting functionality in JWA.

Signed-off-by: Elena Zioga <elena@arrikto.com>

Signed-off-by: Elena Zioga <elena@arrikto.com>
maroroman pushed a commit to maroroman/kubeflow that referenced this issue Feb 7, 2023
@elenzio9 @maroroman
Sorting support for VWA and TWA (kubeflow#6743)
44143ca 
* vwa(front): Enable sorting in VWA (kubeflow#6460)

* Enable sorting functionality in VWA.

Signed-off-by: Elena Zioga <elena@arrikto.com>

* twa(front): Enable sorting in TWA (kubeflow#6460)

* Enable sorting functionality in TWA.

Signed-off-by: Elena Zioga <elena@arrikto.com>

* web-apps(front): Fix unit tests

* Fix unit tests.

Signed-off-by: Elena Zioga <elena@arrikto.com>

Signed-off-by: Elena Zioga <elena@arrikto.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
area/jupyter Issues related to Jupyter kind/feature priority/p1
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@jbottum @kimwnasptd