Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate images to kubeflow-images-public #695

Merged
merged 1 commit into from Apr 20, 2018
Merged

Migrate images to kubeflow-images-public #695

merged 1 commit into from Apr 20, 2018

Conversation

ankushagarwal
Copy link
Contributor

@ankushagarwal ankushagarwal commented Apr 20, 2018

Related to #534

/cc @kunmingg
/cc @pdmack


This change is Reviewable

@pdmack
Copy link
Member

pdmack commented Apr 20, 2018

Looks good. So I guess we'll sequence this before pointing to the newly minted notebook images in the hub dropdown? @ankushagarwal I guess those will also be pushed to "kubeflow-images-public"?
Or should we update that too here in this PR?

@ankushagarwal
Copy link
Contributor Author

Right now I am cloning all images from staging to public, once that's done and tests pass here, we can push this and then you can send a PR to point jupyter notebook the v20180419-0ad94c4e tag

@pdmack
Copy link
Member

pdmack commented Apr 20, 2018

/retest

1 similar comment
@ankushagarwal
Copy link
Contributor Author

/retest

@pdmack
Copy link
Member

pdmack commented Apr 20, 2018

/approve
/lgtm

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: pdmack

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit ac55de6 into kubeflow:master Apr 20, 2018
pdmack pushed a commit to pdmack/kubeflow that referenced this pull request Apr 21, 2018
Related to kubeflow#534
Conflicts:
	bootstrap/README.md
	docs_dev/images.md
	kubeflow/core/tests/tf-job_test.jsonnet
pdmack pushed a commit to pdmack/kubeflow that referenced this pull request Apr 21, 2018
Related to kubeflow#534
Conflicts:
	bootstrap/README.md
	docs_dev/images.md
	kubeflow/core/tests/tf-job_test.jsonnet
pdmack pushed a commit to pdmack/kubeflow that referenced this pull request Apr 21, 2018
Related to kubeflow#534
Conflicts:
	bootstrap/README.md
	docs_dev/images.md
	kubeflow/core/tests/tf-job_test.jsonnet
k8s-ci-robot pushed a commit that referenced this pull request Apr 21, 2018
… gcr.io locations (#703)

* Refactor tensorflow-notebook-image/Dockerfile (#689)

Remove a lot of bloat - install only the minimal set of packages
required to get started with ML. Any packages required can be installed
by the user in the notebook itself using pip install/conda install

Image size has gone down from 12GB to 3GB for cpu image

Having a lot of packages makes it very challenging to maintain them
because of version conflicts

Run everything as jovyan user - this enables user to run conda install
/ pip install without requiring sudo

Add comments on every step

Fixes #668
Fixes #37
Fixes #472
Conflicts:
	components/tensorflow-notebook-image/Dockerfile
	components/tensorflow-notebook-image/build_image.sh
	components/tensorflow-notebook-image/releaser/components/workflows.libsonnet

* Update various images in kubeflow to kubeflow-images-public (#635)

Point them to kubeflow-images-public instead of kubeflow-images-staging

Related to #534
/cc @jlewi
Conflicts:
	bootstrap/Makefile
	bootstrap/README.md

* Migrate images to kubeflow-images-public (#695)

Related to #534
Conflicts:
	bootstrap/README.md
	docs_dev/images.md
	kubeflow/core/tests/tf-job_test.jsonnet

* Update the hub spawner dropdown for latest NB images (#697)
@ankushagarwal ankushagarwal deleted the update-kf-images-staging branch April 22, 2018 02:10
saffaalvi pushed a commit to StatCan/kubeflow that referenced this pull request Feb 11, 2021
yanniszark pushed a commit to arrikto/kubeflow that referenced this pull request Feb 15, 2021
surajkota pushed a commit to surajkota/kubeflow that referenced this pull request Jun 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants