Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CP to v0.1-branch: TF notebook slimming, joyvan pip installs, and new gcr.io locations #703

Merged
merged 4 commits into from Apr 21, 2018
Merged

CP to v0.1-branch: TF notebook slimming, joyvan pip installs, and new gcr.io locations #703

merged 4 commits into from Apr 21, 2018

Conversation

pdmack
Copy link
Member

@pdmack pdmack commented Apr 21, 2018 •
edited

/assign @ankushagarwal
/cc @jlewi
/cc @willb

From Slack discussion of potentially cutting a 0.1.1 release

This change is Reviewable

Ankush Agarwal added 2 commits April 21, 2018 05:48
Refactor tensorflow-notebook-image/Dockerfile (kubeflow#689)
fc212db 
Remove a lot of bloat - install only the minimal set of packages
required to get started with ML. Any packages required can be installed
by the user in the notebook itself using pip install/conda install

Image size has gone down from 12GB to 3GB for cpu image

Having a lot of packages makes it very challenging to maintain them
because of version conflicts

Run everything as jovyan user - this enables user to run conda install
/ pip install without requiring sudo

Add comments on every step

Fixes kubeflow#668
Fixes kubeflow#37
Fixes kubeflow#472
Conflicts:
	components/tensorflow-notebook-image/Dockerfile
	components/tensorflow-notebook-image/build_image.sh
	components/tensorflow-notebook-image/releaser/components/workflows.libsonnet
Update various images in kubeflow to kubeflow-images-public (kubeflow…
2e20a48 
…#635)

Point them to kubeflow-images-public instead of kubeflow-images-staging

Related to kubeflow#534
/cc @jlewi
Conflicts:
	bootstrap/Makefile
	bootstrap/README.md
@pdmack pdmack changed the title CP to V0.1 branch: TF notebook slimming and new gcr.io locations CP to V0.1 branch: TF notebook slimming, joyvan pip installs, and new gcr.io locations Apr 21, 2018
@pdmack
Copy link
Member Author

pdmack commented Apr 21, 2018

/retest

@pdmack
Copy link
Member Author

pdmack commented Apr 21, 2018 •
edited

Ooops, I think I somehow missed this in the CP

# git grep kubeflow-images-staging
kubeflow/core/tests/tf-job_test.jsonnet:                  "image": "gcr.io/kubeflow-images-staging/tf_operator:v20180226-403",

@pdmack
Copy link
Member Author

pdmack commented Apr 21, 2018 •
edited

@jlewi PTAL
tf-job_test.jsonnet test failed
I'm wondering if there is a gap in the 0.1 tag of kubeflow/core/tests/tf-job_test.jsonnet

Ankush Agarwal and others added 2 commits April 21, 2018 07:40
Migrate images to kubeflow-images-public (kubeflow#695)
bc29a84 
Related to kubeflow#534
Conflicts:
	bootstrap/README.md
	docs_dev/images.md
	kubeflow/core/tests/tf-job_test.jsonnet
Update the hub spawner dropdown for latest NB images (kubeflow#697)
a0a8b39
@pdmack
Copy link
Member Author

pdmack commented Apr 21, 2018 •
edited

@jlewi, I manually fixed kubeflow/core/tests/tf-job_test.jsonnet but question still stands I suppose.

@ankushagarwal
Copy link
Contributor

@pdmack I am not sure why tf-job_test would fail. I tried checking out this PR and reverting your changes to tf-job_test and it still passes

jsonnet eval ~/git/kubeflow/kubeflow/core/tests/tf-job_test.jsonnet --jpath ~/git/kubeflow/kubeflow/core

@ankushagarwal
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: ankushagarwal

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit b497fd5 into kubeflow:v0.1-branch Apr 21, 2018
@pdmack pdmack changed the title CP to V0.1 branch: TF notebook slimming, joyvan pip installs, and new gcr.io locations CP to v0.1-branch: TF notebook slimming, joyvan pip installs, and new gcr.io locations Apr 22, 2018
surajkota pushed a commit to surajkota/kubeflow that referenced this pull request Jun 13, 2022
@Bobgy @k8s-ci-robot
Two examples for disabling istio injection (kubeflow#703)
b556503
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jlewi jlewi Awaiting requested review from jlewi

@willb willb Awaiting requested review from willb

Assignees

@ankushagarwal ankushagarwal

Labels
approved lgtm size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@pdmack @ankushagarwal @k8s-ci-robot