Bump the controller-runtime version to 0.16.2 #7322
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There are a lot of improvements, optimizations and bug fixes in the latest version, related to the controller-runtime client which is used in admission-webhook. Signed-off-by: Tzvetomir Stoyanov (VMware) <tz.stoyanov@gmail.com>
The latest version of controller-runtime client requires to set in advance a logger, used by the client. Signed-off-by: Tzvetomir Stoyanov (VMware) <tz.stoyanov@gmail.com>
The latest version of controller-runtime package requires golang v.1.21 for building. Signed-off-by: Tzvetomir Stoyanov (VMware) <tz.stoyanov@gmail.com>
|
/lgtm |
|
/assign @thesuperzapper |
5 tasks
|
Thanks for the PR @tzstoyanov! I can take a stab at it. Also, if you have the cycles, could you take a stab at mine for the notebooks controller? #7152 The changes should be quite similar, and I'm using that as my reference as I review this PR as well /assign @kimwnasptd |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: discordianfish The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
@discordianfish just to verify since this got merged. The tests weren't triggered because it was @tzstoyanov's first PR in this repo. Did you also run the code or built and tested the image? |
kimwnasptd
pushed a commit
to kimwnasptd/kubeflow
that referenced
this pull request
Oct 13, 2023
* Bump the controller-runtime version to 0.16.2 There are a lot of improvements, optimizations and bug fixes in the latest version, related to the controller-runtime client which is used in admission-webhook. Signed-off-by: Tzvetomir Stoyanov (VMware) <tz.stoyanov@gmail.com> * Set logger for controller-runtime The latest version of controller-runtime client requires to set in advance a logger, used by the client. Signed-off-by: Tzvetomir Stoyanov (VMware) <tz.stoyanov@gmail.com> * Use golang version 1.21 for container build The latest version of controller-runtime package requires golang v.1.21 for building. Signed-off-by: Tzvetomir Stoyanov (VMware) <tz.stoyanov@gmail.com> --------- Signed-off-by: Tzvetomir Stoyanov (VMware) <tz.stoyanov@gmail.com>
This was referenced Oct 13, 2023
google-oss-prow bot
pushed a commit
that referenced
this pull request
Oct 15, 2023
* Bump the controller-runtime version to 0.16.2 (#7322) * Bump the controller-runtime version to 0.16.2 There are a lot of improvements, optimizations and bug fixes in the latest version, related to the controller-runtime client which is used in admission-webhook. Signed-off-by: Tzvetomir Stoyanov (VMware) <tz.stoyanov@gmail.com> * Set logger for controller-runtime The latest version of controller-runtime client requires to set in advance a logger, used by the client. Signed-off-by: Tzvetomir Stoyanov (VMware) <tz.stoyanov@gmail.com> * Use golang version 1.21 for container build The latest version of controller-runtime package requires golang v.1.21 for building. Signed-off-by: Tzvetomir Stoyanov (VMware) <tz.stoyanov@gmail.com> --------- Signed-off-by: Tzvetomir Stoyanov (VMware) <tz.stoyanov@gmail.com> * poddefaults: Bump golang to 1.20 (#7338) Signed-off-by: Kimonas Sotirchos <kimwnasptd@gmail.com> --------- Signed-off-by: Tzvetomir Stoyanov (VMware) <tz.stoyanov@gmail.com> Signed-off-by: Kimonas Sotirchos <kimwnasptd@gmail.com> Co-authored-by: Tzvetomir Stoyanov <tz.stoyanov@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes issue #6708
There are a lot of improvements, optimizations and bug fixes in the latest version, related to the controller-runtime client which is used in admission-webhook. A new cache logic is introduced, which reduces the amount of get requests used by the controller-runtime client. That avoids hitting the client-side throttling.