Cherry-pick: PodDefaults versions bump #7322 and #7338 #7337
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Bump the controller-runtime version to 0.16.2 There are a lot of improvements, optimizations and bug fixes in the latest version, related to the controller-runtime client which is used in admission-webhook. Signed-off-by: Tzvetomir Stoyanov (VMware) <tz.stoyanov@gmail.com> * Set logger for controller-runtime The latest version of controller-runtime client requires to set in advance a logger, used by the client. Signed-off-by: Tzvetomir Stoyanov (VMware) <tz.stoyanov@gmail.com> * Use golang version 1.21 for container build The latest version of controller-runtime package requires golang v.1.21 for building. Signed-off-by: Tzvetomir Stoyanov (VMware) <tz.stoyanov@gmail.com> --------- Signed-off-by: Tzvetomir Stoyanov (VMware) <tz.stoyanov@gmail.com>
|
Looks like unit tests are breaking for the controller, which were not triggered in #7322 Sending a PR to fix |
kimwnasptd
changed the title
Signed-off-by: Kimonas Sotirchos <kimwnasptd@gmail.com>
kimwnasptd
changed the title
kimwnasptd
changed the title
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: thesuperzapper The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick