[openmpi] support imagePullSecrets
#771
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
everpeace
force-pushed
the
openmpi-imagePullSecret
branch
from
b372219
to
15172ba
Compare
inc0
approved these changes
May 8, 2018
|
@inc0 Thank you for your review recently 👍 🙇
Yes, I think we should. I'm happy to contribute to it. :-) |
|
/lgtm |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jiezhang The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the problem?
When using openmpi package, end users often build their own docker images which would contain some their custom code and these images are possibly published to private repositories.
But, openmpi package doesn't support
imagePullSecretssection so users can not pull from private repositories.How the PR fixes it
In Kubernetes, I think there are two ways to pull private images.
The first one(add secrets to service accounts) would need a strong permission, that is
editforserviceaccoutnsresources. This operation would be kind of administrative operaiotns. Thus, end users would not have such permission. So, I prefer to support the second one.So, the PR
imagePullSecretsparameter. This should be comma separated secret names to pull private imags. The parameter will be expanded toimagePullSecretssecition to pods definition.=="null"), no secret would be fed to podsThis change is