Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[openmpi] support imagePullSecrets #771

Merged
merged 1 commit into from
May 9, 2018
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions kubeflow/openmpi/prototypes/openmpi.jsonnet
Original file line number Diff line number Diff line change
Expand Up @@ -10,6 +10,7 @@
// @optionalParam init string null Command to bootstrap the containers. Defaults to init.sh.
// @optionalParam exec string null Command to execute in master after bootstrap is done. It sleeps indefinitely if not set.
// @optionalParam imagePullPolicy string IfNotPresent Image pull policy (either IfNotPresent or Always).
// @optionalParam imagePullSecrets string null Comma-delimited list of secret names to use credentials in pulling your docker images.
// @optionalParam gpu number 0 Number of GPUs per worker.
// @optionalParam cpu string null CPU limits per worker.
// @optionalParam memory string null Memory limits per worker.
Expand Down
1 change: 1 addition & 0 deletions kubeflow/openmpi/workloads.libsonnet
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,7 @@ local ROLE_WORKER = "worker";
schedulerName: params.schedulerName,
volumes: $.volumes(params),
containers: $.containers(params, role),
imagePullSecrets: [{ name: secret } for secret in util.toArray(params.imagePullSecrets)],
serviceAccountName: serviceaccount.name(params),
nodeSelector: $.nodeSelector(params, role),
},
Expand Down