Skip to content

Commit

Permalink
kustomize 5.2.1 (#2654)
Browse files Browse the repository at this point in the history
* Update install_kustomize.sh

Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com>

* Update README.md

Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com>

* Update pull_request_template.md

Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com>

* deprecate old kustomize

Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com>

* update readme.md

Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com>

* update readme and Go to the pipelines version

Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com>

---------

Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com>
  • Loading branch information
juliusvonkohout committed Mar 15, 2024
1 parent 68652a1 commit 03ddeb8
Show file tree
Hide file tree
Showing 5 changed files with 10 additions and 10 deletions.
2 changes: 1 addition & 1 deletion .github/pull_request_template.md
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,6 @@ Resolves #

**Checklist:**
- [ ] Unit tests pass:
**Make sure you have installed kustomize == 5.0.3**
**Make sure you have installed kustomize == 5.2.1+**
1. `make generate-changed-only`
2. `make test`
8 changes: 4 additions & 4 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -85,9 +85,9 @@ The `example` directory contains an example kustomization for the single command

### Prerequisites

- `Kubernetes` (up to `1.27`) with a default [StorageClass](https://kubernetes.io/docs/concepts/storage/storage-classes/)
- `kustomize` [5.0.3](https://github.com/kubernetes-sigs/kustomize/releases/tag/kustomize%2Fv5.0.3)
- :warning: Kubeflow is not compatible with earlier versions of Kustomize. This is because we need the [`sortOptions`](https://kubectl.docs.kubernetes.io/references/kustomize/kustomization/sortoptions/) field, which is only available in Kustomize 5 and onwards https://github.com/kubeflow/manifests/issues/2388.
- `Kubernetes` (around `1.28`) with a default [StorageClass](https://kubernetes.io/docs/concepts/storage/storage-classes/)
- `kustomize` [5.2.1+](https://github.com/kubernetes-sigs/kustomize/releases/tag/kustomize%2Fv5.2.1)
- :warning: Kubeflow is not compatible with earlier versions of Kustomize. One of the reasons is that we need the [`sortOptions`](https://kubectl.docs.kubernetes.io/references/kustomize/kustomization/sortoptions/) field, which is only available in Kustomize 5 and onwards https://github.com/kubeflow/manifests/issues/2388.
- `kubectl`

---
Expand Down Expand Up @@ -508,4 +508,4 @@ The Manifest Working Group releases Kubeflow based on the [release timeline](htt
- **Q:** What versions of Istio, Knative, Cert-Manager, Argo, ... are compatible with Kubeflow? \
**A:** Please refer to each individual component's documentation for a dependency compatibility range. For Istio, Knative, Dex, Cert-Manager and OIDC-AuthService, the versions in `common` are the ones we have validated.
- **Q:** Can I use earlier version of Kustomize with Kubeflow manifests?
**A:** The manual installation instructions work with Kustomize 3.2. To use the one-liner installation you'll need to comment out the `sortOptions` section in the `example/kustomization.yaml`.
**A:** No, it is not supported anymore, although it might be possible with manual effort.
4 changes: 2 additions & 2 deletions go.mod
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
module github.com/kubeflow/manifests

go 1.12
go 1.20

require sigs.k8s.io/kustomize/kustomize/v3 v3.2.1
require sigs.k8s.io/kustomize/kustomize/v3 v5.2.1
2 changes: 1 addition & 1 deletion tests/e2e/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ This test is using the following Kubeflow CRDs:
The heart of this test is the `mnist.py` python script, which applies and waits
for the CRDs to complete. The python scripts are all expecting that
1. `kubectl` is configured with access to a Kubeflow cluster
2. `kustomize` 5.0.3+ is available
2. `kustomize` 5.2.1+ is available
3. The KFP backend is proxied to localhost

While the `mnist.py` is used for running the test, it is advised to use the
Expand Down
4 changes: 2 additions & 2 deletions tests/gh-actions/install_kustomize.sh
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
#!/bin/bash
set -e
curl --silent --location --remote-name "https://github.com/kubernetes-sigs/kustomize/releases/download/kustomize%2Fv5.0.3/kustomize_v5.0.3_linux_amd64.tar.gz"
tar -xzvf kustomize_v5.0.3_linux_amd64.tar.gz
curl --silent --location --remote-name "https://github.com/kubernetes-sigs/kustomize/releases/download/kustomize%2Fv5.2.1/kustomize_v5.2.1_linux_amd64.tar.gz"
tar -xzvf kustomize_v5.2.1_linux_amd64.tar.gz
chmod a+x kustomize
sudo mv kustomize /usr/local/bin/kustomize

0 comments on commit 03ddeb8

Please sign in to comment.