kustomize 5.2.1 #2654
kustomize 5.2.1 #2654
Conversation
|
/hold |
|
I saw that you wrote a hold comment If we are going to start supporting kustomize 5.x.x from this PR, I would like to ask to change: https://github.com/kubeflow/manifests/blob/master/tests/gh-actions/install_kustomize.sh |
Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com>
Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com>
Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com>
juliusvonkohout
force-pushed
the
kustomize-5.2.1
branch
from
f15eec6
to
7c93608
Compare
|
/unhold |
Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com>
Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com>
There was a problem hiding this comment.
You probable also need:
Line 16 in 68652a1
There's also an old reference to Kustomize v4 here:
manifests/common/knative/README.md
Line 40 in 68652a1
There's also the go.mod and go.sum, which I don't know what is being used for. We have no Go code in the repository? 🤔
Lines 1 to 5 in 68652a1
The docs/KustomizeBestPractices.md probably also needs to be updated, as it recommends use of deprecated functionality
Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com>
|
@AndersBennedsgaard manifests/common/knative/README.md should be updated in your PR. Yes go is not needed it seems, but i used the version form kubeflow/pipelines |
|
@diegolovison @rimolive @AndersBennedsgaard @kimwnasptd any further suggestions? |
|
CC @kubeflow/release-team and @kubeflow/release-managers for discussion and LGTMS /hold |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: AndersBennedsgaard, diegolovison, juliusvonkohout The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
|
/lgtm Let's sync with the WGs that the new dependency version for kustomize is 5.2.1 |
|
/unhold |
* Update install_kustomize.sh Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com> * Update README.md Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com> * Update pull_request_template.md Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com> * deprecate old kustomize Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com> * update readme.md Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com> * update readme and Go to the pipelines version Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com> --------- Signed-off-by: juliusvonkohout <45896133+juliusvonkohout@users.noreply.github.com> Signed-off-by: Anders Bennedsgaard <abbennedsgaard@gmail.com>
@rimolive
#2653