Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update mxnet-operator manifest to v1 #1326

Merged
merged 1 commit into from
Jun 26, 2020
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
52 changes: 49 additions & 3 deletions mxnet-job/mxnet-operator/base/crd.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,55 @@ metadata:
name: mxjobs.kubeflow.org
spec:
group: kubeflow.org
version: v1
scope: Namespaced
names:
kind: MXJob
plural: mxjobs
singular: mxjob
version: v1beta1
scope: Namespaced
plural: mxjobs
subresources:
status: {}
validation:
openAPIV3Schema:
properties:
spec:
properties:
mxReplicaSpecs:
properties:
# The validation works when the configuration contains
# `Worker`, `Server`, `Scheduler`,
# `TunerTracker`, `TunerServer`, `Tuner`,
# Otherwise it will not be validated.
Scheduler:
properties:
replicas:
type: integer
minimum: 1
maximum: 1
Worker:
properties:
replicas:
type: integer
minimum: 1
Server:
properties:
replicas:
type: integer
minimum: 1
TunerTracker:
properties:
replicas:
type: integer
minimum: 1
maximum: 1
TunerServer:
properties:
replicas:
type: integer
minimum: 1
Tuner:
properties:
replicas:
type: integer
minimum: 1
maximum: 1
4 changes: 1 addition & 3 deletions mxnet-job/mxnet-operator/base/deployment.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -13,9 +13,7 @@ spec:
spec:
containers:
- command:
- /opt/kubeflow/mxnet-operator.v1beta1
- --alsologtostderr
- -v=1
- /opt/kubeflow/mxnet-operator.v1
env:
- name: MY_POD_NAMESPACE
valueFrom:
Expand Down
4 changes: 2 additions & 2 deletions mxnet-job/mxnet-operator/base/kustomization.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -11,5 +11,5 @@ commonLabels:
kustomize.component: mxnet-operator
images:
- name: mxjob/mxnet-operator
newName: mxjob/mxnet-operator
newTag: v1beta1
newName: kubeflow/mxnet-operator
newTag: v1.0.0-20200625
10 changes: 7 additions & 3 deletions mxnet-job/mxnet-operator/overlays/application/application.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -6,11 +6,11 @@ spec:
selector:
matchLabels:
app.kubernetes.io/name: mxnet-operator
app.kubernetes.io/instance: mxnet-operator-v0.7.0
app.kubernetes.io/instance: mxnet-operator-v1.0.0
app.kubernetes.io/component: mxnet
app.kubernetes.io/part-of: kubeflow
app.kubernetes.io/managed-by: kfctl
app.kubernetes.io/version: v0.7.0
app.kubernetes.io/version: v1.0.0
componentKinds:
- group: apps
kind: Deployment
Expand All @@ -20,18 +20,22 @@ spec:
kind: MXJob
descriptor:
type: "mxnet-operator"
version: "v1beta1"
version: "v1"
description: "mxnet-operator allows users to create and manage the \"MXJob\" custom resource."
maintainers:
- name: Lei Su
email: suleisl2000@hotmail.com
- name: Yuan Tang
email: terrytangyuan@gmail.com
- name: Jiaxin Shan
email: seedjeffwan@gmail.com
owners:
- name: Lei Su
email: suleisl2000@hotmail.com
- name: Yuan Tang
email: terrytangyuan@gmail.com
- name: Jiaxin Shan
email: seedjeffwan@gmail.com
keywords:
- "MXjob"
- "mxnet-operator"
Expand Down