Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Setup KF Model Registry GH tests #2694

Closed
wants to merge 1 commit into from

Conversation

lampajr
Copy link
Member

@lampajr lampajr commented Apr 29, 2024

Which issue is resolved by this Pull Request:
Resolves #

Followup of #2631

Description of your changes:

Add GH test for Kubeflow Model Registry component.

Checklist:

  • Unit tests pass:
    Make sure you have installed kustomize == 5.2.1+
    1. make generate-changed-only
    2. make test

Copy link

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: lampajr
Once this PR has been reviewed and has the lgtm label, please assign kimwnasptd for approval. For more information see the Kubernetes Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@lampajr
Copy link
Member Author

lampajr commented Apr 29, 2024

Note that at the moment there is no apps/model-registry/upstream content.

Do you want to add that from main or v0.2.0-alpha branch tag?

@lampajr
Copy link
Member Author

lampajr commented Apr 29, 2024

fyi @tarilabs @rimolive

@tarilabs
Copy link
Member

Do you want to add that from main or v0.2.0-alpha branch?

I believe it will be meaningful to start tracking https://github.com/kubeflow/model-registry/releases/tag/v0.2.0-alpha
let me know if you need a proper branch or tag is sufficient like atm

@lampajr
Copy link
Member Author

lampajr commented Apr 29, 2024

I believe it will be meaningful to start tracking https://github.com/kubeflow/model-registry/releases/tag/v0.2.0-alpha

+1, if we all agree on that I will add the content as part of this PR

let me know if you need a proper branch or tag is sufficient like atm

The script to sync the manifest requires a generic git ref, therefore the tag is absolutely fine.

Signed-off-by: Andrea Lamparelli <a.lamparelli95@gmail.com>
Copy link
Member

@tarilabs tarilabs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm thanks @lampajr

@rimolive
Copy link
Member

/lgtm

cc @juliusvonkohout

@rimolive
Copy link
Member

rimolive commented May 1, 2024

@lampajr Thank you for your contribution! After discussing with Manifests WG leads we decided to cherry-pick the functional tests in #2697 so we add the manifest and run the tests.

Looking for your ack so I can close this PR in favor of #2697.

@lampajr
Copy link
Member Author

lampajr commented May 1, 2024

@lampajr Thank you for your contribution! After discussing with Manifests WG leads we decided to cherry-pick the functional tests in #2697 so we add the manifest and run the tests.

Looking for your ack so I can close this PR in favor of #2697.

That's fine for me, thanks @rimolive !

@lampajr
Copy link
Member Author

lampajr commented May 1, 2024

Closing this in favor of #2697

@lampajr lampajr closed this May 1, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants