Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update kubeflow/model-registry manifests from v0.2.0-alpha #2697

Conversation

rimolive
Copy link
Member

@rimolive rimolive commented Apr 30, 2024

Which issue is resolved by this Pull Request:
Supersedes #2694

Description of your changes:

Checklist:

  • Unit tests pass:
    Make sure you have installed kustomize == 5.2.1+
    1. make generate-changed-only
    2. make test

Signed-off-by: Ricardo M. Oliveira <rmartine@redhat.com>
@juliusvonkohout
Copy link
Member

juliusvonkohout commented Apr 30, 2024

We should update the model registry synchronization script as I did for Katib in #2698

@lampajr
Copy link
Member

lampajr commented May 1, 2024

Thanks @rimolive, note that the manifests README and OWNERS files that have been added with kubeflow/model-registry#69 were not included in v0.2.0-alpha tag yet (as the PR has been merged yesterday).

As temporary solution, if really needed, we could add them manually as part of this PR. Wdyt?

@rimolive rimolive force-pushed the sync-kubeflow-model-registry-manifests-v0.2.0-alpha branch 2 times, most recently from 1be98d8 to 32973e5 Compare May 3, 2024 10:47
@rimolive
Copy link
Member Author

rimolive commented May 3, 2024

@lampajr Done

@rimolive
Copy link
Member Author

rimolive commented May 3, 2024

/hold

Found an issue in the sync script.

Signed-off-by: Andrea Lamparelli <a.lamparelli95@gmail.com>
Signed-off-by: Ricardo M. Oliveira <rmartine@redhat.com>
@rimolive rimolive force-pushed the sync-kubeflow-model-registry-manifests-v0.2.0-alpha branch from 32973e5 to 101fd6d Compare May 3, 2024 16:47
@rimolive
Copy link
Member Author

rimolive commented May 3, 2024

/unhold

@rimolive
Copy link
Member Author

rimolive commented May 4, 2024

cc @juliusvonkohout

@juliusvonkohout
Copy link
Member

networkpolicies etc. in follow up PRs

/lgtm
/approve

Copy link

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: juliusvonkohout, lampajr, rimolive

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@google-oss-prow google-oss-prow bot merged commit e121662 into kubeflow:master May 6, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants