Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add finalizers to roles, change argo executor to k8sapi #276

Closed
wants to merge 5 commits into from
Closed

Add finalizers to roles, change argo executor to k8sapi #276

wants to merge 5 commits into from

Conversation

blublinsky
Copy link
Contributor

@blublinsky blublinsky commented Aug 14, 2019 •
edited by jlewi

Which issue is resolved by this Pull Request:
Resolves #
deployment issues on OpenShift
Description of your changes:
Add finalizers to roles

Checklist:

  • Unit tests have been rebuilt:
    1. cd manifests/tests
    2. make generate
    3. make test

This change is Reviewable

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it!) and we'll verify it.

What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@k8s-ci-robot
Copy link
Contributor

Hi @blublinsky. Thanks for your PR.

I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@blublinsky
Copy link
Contributor Author

@googlebot I signed it!

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@blublinsky
Copy link
Contributor Author

/assign @zhenghuiwang

@zhenghuiwang
Copy link
Contributor

/assign @richardsliu for tf-jobs config
/unassign @zhenghuiwang

@k8s-ci-robot
Copy link
Contributor

@zhenghuiwang: GitHub didn't allow me to assign the following users: config, for, tf-jobs.

Note that only kubeflow members, repo collaborators and people who have commented on this issue/PR can be assigned. Additionally, issues/PRs can only have 10 assignees at the same time.
For more information please see the contributor guide

In response to this:

/assign @richardsliu for tf-jobs config
/unassign @zhenghuiwang

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@richardsliu
Copy link
Contributor

@blublinsky
Can you add an explanation for why this is needed?

Also a couple of things:

  1. katib-v1alpha2 is going to be deprecated. Changes should be made to https://github.com/kubeflow/manifests/tree/master/katib-v1alpha2.
  2. There are other operators like pytorch-job, mpi-job, etc. Should this be added to all of them?

@blublinsky
Copy link
Contributor Author

@richardsliu This changes are necessary for OpenShift/IBM execution, due to their security constraints. As operator is destroying, its using finalizers and need to have access to it.
I added only to the ones I used, but they should be for all of them

@richardsliu
Copy link
Contributor

@blublinsky Can you at least update katib-v1alpha2, since katib-v1alpha1 will be deprecated soon (in about a month)?

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by:
To complete the pull request process, please assign richardsliu
You can assign the PR to them by writing /assign @richardsliu in a comment when ready.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@blublinsky
Copy link
Contributor Author

This change is my best guess, I did not try it and v2 is significantly different

@richardsliu
Copy link
Contributor

/ok-to-test

@richardsliu
Copy link
Contributor

Generally lgtm. Can you resolve the conflict and fix the tests?

@blublinsky
Copy link
Contributor Author

Conflicts resolved

@blublinsky
Copy link
Contributor Author

blublinsky commented Aug 23, 2019 via email

@blublinsky
Copy link
Contributor Author

Looking at the tests and slightly confused. The test that fails is FAIL: TestTfJobOperatorOverlaysIstio (0.05s)
When I am looking at the test output, it looks like tfjobs/finalizers was not picked up

@richardsliu
Copy link
Contributor

You need to fix files like these:
https://github.com/kubeflow/manifests/blob/master/tests/tf-job-operator-overlays-istio_test.go

They can be run locally by doing make test.

@blublinsky
Copy link
Contributor Author

Thanks Richard

@k8s-ci-robot
Copy link
Contributor

@blublinsky: The following test failed, say /retest to rerun them all:

Test name Commit Details Rerun command
kubeflow-manifests-presubmit d4c4b6a link /test kubeflow-manifests-presubmit

Full PR test history. Your PR dashboard. Please help us cut down on flakes by linking to an open issue when you hit one in your PR.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here.

@blublinsky
Copy link
Contributor Author

blublinsky commented Aug 23, 2019 via email

@kkasravi
Copy link
Contributor

kkasravi commented Aug 24, 2019 via email

@blublinsky
Copy link
Contributor Author

blublinsky commented Aug 26, 2019 via email

@kkasravi
Copy link
Contributor

I believe Clive Seldon submitted a fix
https://github.com/kubeflow/manifests/pull/322/files#diff-a8346fa7ae5f317402b5ef75772924abR7

@blublinsky
Copy link
Contributor Author

blublinsky commented Aug 27, 2019 via email

@blublinsky blublinsky mentioned this pull request Sep 5, 2019
Closed
@kkasravi kkasravi mentioned this pull request Oct 19, 2019
Closed
@jlewi
Copy link
Contributor

jlewi commented Nov 5, 2019

/assign @jlewi

@blublinsky sorry this PR is taking so long; do you want to try to update?

The RBAC role changes seem like pretty straightforward changes. I apologize this PR fell through the cracks and is taking so long.

Here's my suggestion to get this PR fixed and merged

  • Rebase on master

  • Make sure the only changes are modifying cluster roles to add finalizers (I see a couple other changes in the PR)

  • Regenerate the tests by running make generate

    • Revert any changed tests that aren't related to the manifests that are being modified in this PR.

@blublinsky blublinsky closed this Nov 6, 2019
adam-postera pushed a commit to postera-ai/kf-manifests that referenced this pull request Apr 11, 2023
@mbaijal
Update Pytorch and Tensorflow Notebook Containers (kubeflow#276)
325b65c 
* update notebook dockerfiles

* update requirements

* Update the notebook dropdown

* Update website

* Add TF changes

* Drop the date from the TF tags
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kkasravi kkasravi Awaiting requested review from kkasravi

@kunmingg kunmingg Awaiting requested review from kunmingg

Assignees

@jlewi jlewi

@richardsliu richardsliu

Labels
cla: yes ok-to-test size/S
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@blublinsky @googlebot @k8s-ci-robot @zhenghuiwang @richardsliu @kkasravi @jlewi