-
Notifications
You must be signed in to change notification settings - Fork 868
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Workaround workload identity bug and fix node autoprovisioning. #498
Conversation
* See kubeflow/kfctl#48 1.14.6-gke-13 has a bug with workload identity so to work around it we temporarily pin to 1.14.6-gke-2. * Fix node autoprovisioning defaults (kubeflow/kubeflow#4259) we need to set the default service account otherwise we won't be able to pull images from private GCR. * Note: We can't set both service account and scopes so we only set the service account.
/assign @lluunn |
I checked the cluster settings
The auto provisioning service account is set. It looks like OAuth scopes got populated but don't include dev storage. When I tried setting both though I got an error
Lets hope when its using GCR it using IAM and not scopes. We should run a simple test to verify. |
/assign @kunmingg |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: kunmingg The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Error waiting for metadata deployment.
|
/test all |
See [GCP] Workload identity not working; gke metadata server getting killed for failing liveness probe kfctl#48 1.14.6-gke-13 has
a bug with workload identity so to work around it we temporarily
pin to 1.14.6-gke-2.
Fix node autoprovisioning defaults ([GCP] Node Auto provisioner pool is missing VM service account and oauth scopes kubeflow#4259) we need to set
the default service account otherwise we won't be able to
pull images from private GCR.
the service account.
Which issue is resolved by this Pull Request:
Resolves #
Description of your changes:
Checklist:
cd manifests/tests
make generate
make test
This change is