Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[aws] Clean up istio gateway and virtual services. #567

Merged
merged 2 commits into from
Oct 24, 2019
Merged

[aws] Clean up istio gateway and virtual services. #567

merged 2 commits into from
Oct 24, 2019

Conversation

Jeffwan
Copy link
Member

@Jeffwan Jeffwan commented Oct 24, 2019 •
edited by jlewi
Loading

Which issue is resolved by this Pull Request:

Description of your changes:

  1. aws originally use kubeflow-gateway from 0.5 and now start using common one from istio/istio/base/kf-istio-resources.yaml. No need to keep original one anymore and make some clean up.
k get gateways --all-namespaces
NAMESPACE   NAME               AGE
kubeflow    kubeflow-gateway   12m
istio-system    kubeflow-gateway   12m
  1. Add default istio-system for deletion purpose.

Checklist:

  • Unit tests have been rebuilt:
    1. cd manifests/tests
    2. make generate
    3. make test

This change is Reviewable

@Jeffwan Jeffwan mentioned this pull request Oct 24, 2019
Closed
@richardsliu
Copy link
Contributor

/lgtm
/approve

@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: richardsliu

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot merged commit 60fa203 into kubeflow:master Oct 24, 2019
@Jeffwan Jeffwan deleted the aws-0.7 branch October 24, 2019 18:56
Jeffwan added a commit to Jeffwan/manifests that referenced this pull request Oct 24, 2019
@Jeffwan
[aws] Clean up istio gateway and virtual services. (kubeflow#567)
6c70401 
* Add default namespace for istio-ingress

* [aws] Remove istio gateway and virtualservice
k8s-ci-robot pushed a commit that referenced this pull request Oct 24, 2019
@Jeffwan @k8s-ci-robot
Cherry pick #518 #567 to v0.7-branch (#572)
e1ffa14 
* Add application name for seldon and mpi-operator (#518)

* [aws] Clean up istio gateway and virtual services. (#567)

* Add default namespace for istio-ingress

* [aws] Remove istio gateway and virtualservice
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IronPan IronPan Awaiting requested review from IronPan

@richardsliu richardsliu Awaiting requested review from richardsliu

Assignees

@richardsliu richardsliu

Labels
approved cla: yes lgtm size/L
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Jeffwan @richardsliu @k8s-ci-robot @googlebot