-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(Backend + SDK): Update kfp backend and kubernetes sdk to support tolerations #10471
Conversation
Hi @droctothorpe. Thanks for your PR. I'm waiting for a kubeflow member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. |
a382a77
to
002bfe9
Compare
002bfe9
to
3adeda4
Compare
3adeda4
to
cad6929
Compare
Rebased and resolved merge conflicts. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @droctothorpe!
6c5fe9d
to
9036732
Compare
@connor-mccarthy We addressed all feedback. We put it in a discrete commit to make review easier, but happy to squash if that's helpful. Thank you! 🙏 |
/ok-to-test |
fyi @droctothorpe your tests will be failing because the backend is pulling the kubernetes_platform package from github upstream instead of local packages. This is why the PRs our team created have to at least separate into two PRs. |
Doh. That makes sense. I'll rebase and resolve merge conflicts in the other PR this evening. Thanks, @Tomcli! |
9036732
to
91affce
Compare
91affce
to
7e8cff9
Compare
Signed-off-by: droctothorpe <mythicalsunlight@gmail.com> Co-authored-by: edmondop <edmondo.porcu@gmail.com> Co-authored-by: tarat44 <32471142+tarat44@users.noreply.github.com>
Signed-off-by: droctothorpe <mythicalsunlight@gmail.com> Co-authored-by: edmondop <edmondo.porcu@gmail.com> Co-authored-by: tarat44 <32471142+tarat44@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/approve
Thank you, @droctothorpe!
ab08ffb
to
aadbb5a
Compare
aadbb5a
to
2339989
Compare
Still trying to debug why the license checks are failing in CI. |
a6ba900
to
6819b40
Compare
/retest-required |
All required tests are finally passing. Thanks for your patience! CC @connor-mccarthy. Just gonna squash the last few commits to get past the DCO gate. |
Signed-off-by: droctothorpe <mythicalsunlight@gmail.com> Co-authored-by: edmondop <edmondo.porcu@gmail.com> Co-authored-by: tarat44 <32471142+tarat44@users.noreply.github.com>
a7f6185
to
dda1ec3
Compare
@droctothorpe: The following tests failed, say
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository. I understand the commands that are listed here. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @droctothorpe
/lgtm
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: chensun, connor-mccarthy The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
… tolerations (kubeflow#10471) * feat(Backend + SDK): Update kfp backend and kubernetes sdk to support tolerations Signed-off-by: droctothorpe <mythicalsunlight@gmail.com> Co-authored-by: edmondop <edmondo.porcu@gmail.com> Co-authored-by: tarat44 <32471142+tarat44@users.noreply.github.com> * Address PR review 1 Signed-off-by: droctothorpe <mythicalsunlight@gmail.com> Co-authored-by: edmondop <edmondo.porcu@gmail.com> Co-authored-by: tarat44 <32471142+tarat44@users.noreply.github.com> * Refactor add_toleration to use Python primitives Signed-off-by: droctothorpe <mythicalsunlight@gmail.com> Co-authored-by: edmondop <edmondo.porcu@gmail.com> Co-authored-by: tarat44 <32471142+tarat44@users.noreply.github.com> * Update go.mod to pull in latest kubernetes_platform package Signed-off-by: droctothorpe <mythicalsunlight@gmail.com> Co-authored-by: edmondop <edmondo.porcu@gmail.com> Co-authored-by: tarat44 <32471142+tarat44@users.noreply.github.com> --------- Signed-off-by: droctothorpe <mythicalsunlight@gmail.com> Co-authored-by: edmondop <edmondo.porcu@gmail.com> Co-authored-by: tarat44 <32471142+tarat44@users.noreply.github.com>
… tolerations (kubeflow#10471) * feat(Backend + SDK): Update kfp backend and kubernetes sdk to support tolerations Signed-off-by: droctothorpe <mythicalsunlight@gmail.com> Co-authored-by: edmondop <edmondo.porcu@gmail.com> Co-authored-by: tarat44 <32471142+tarat44@users.noreply.github.com> * Address PR review 1 Signed-off-by: droctothorpe <mythicalsunlight@gmail.com> Co-authored-by: edmondop <edmondo.porcu@gmail.com> Co-authored-by: tarat44 <32471142+tarat44@users.noreply.github.com> * Refactor add_toleration to use Python primitives Signed-off-by: droctothorpe <mythicalsunlight@gmail.com> Co-authored-by: edmondop <edmondo.porcu@gmail.com> Co-authored-by: tarat44 <32471142+tarat44@users.noreply.github.com> * Update go.mod to pull in latest kubernetes_platform package Signed-off-by: droctothorpe <mythicalsunlight@gmail.com> Co-authored-by: edmondop <edmondo.porcu@gmail.com> Co-authored-by: tarat44 <32471142+tarat44@users.noreply.github.com> --------- Signed-off-by: droctothorpe <mythicalsunlight@gmail.com> Co-authored-by: edmondop <edmondo.porcu@gmail.com> Co-authored-by: tarat44 <32471142+tarat44@users.noreply.github.com>
… tolerations (kubeflow#10471) * feat(Backend + SDK): Update kfp backend and kubernetes sdk to support tolerations Signed-off-by: droctothorpe <mythicalsunlight@gmail.com> Co-authored-by: edmondop <edmondo.porcu@gmail.com> Co-authored-by: tarat44 <32471142+tarat44@users.noreply.github.com> * Address PR review 1 Signed-off-by: droctothorpe <mythicalsunlight@gmail.com> Co-authored-by: edmondop <edmondo.porcu@gmail.com> Co-authored-by: tarat44 <32471142+tarat44@users.noreply.github.com> * Refactor add_toleration to use Python primitives Signed-off-by: droctothorpe <mythicalsunlight@gmail.com> Co-authored-by: edmondop <edmondo.porcu@gmail.com> Co-authored-by: tarat44 <32471142+tarat44@users.noreply.github.com> * Update go.mod to pull in latest kubernetes_platform package Signed-off-by: droctothorpe <mythicalsunlight@gmail.com> Co-authored-by: edmondop <edmondo.porcu@gmail.com> Co-authored-by: tarat44 <32471142+tarat44@users.noreply.github.com> --------- Signed-off-by: droctothorpe <mythicalsunlight@gmail.com> Co-authored-by: edmondop <edmondo.porcu@gmail.com> Co-authored-by: tarat44 <32471142+tarat44@users.noreply.github.com>
Description of your changes:
This PR adds support for tolerations to the driver and kubernetes_platform SDK.
It is a follow up to #10442, which updated the protobuf and Golang stub.
It follows the excellent example set by #10427.
Huge thanks to @Tomcli for paving the way and sharing how to validate things end to end.
Checklist: