Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix prow merge's incompatibility with new synced labels. #102

Closed
kunmingg opened this issue Apr 7, 2018 · 5 comments
Closed

Fix prow merge's incompatibility with new synced labels. #102

kunmingg opened this issue Apr 7, 2018 · 5 comments
Assignees

Comments

@kunmingg
Copy link
Contributor

kunmingg commented Apr 7, 2018

During label auto-sync, we had a label rename: "do-not-merge/work-in-progress" -> "status/in progress", which might cause prow merge uncompleted PR.
One false positive merge here: kubeflow/community#41 (comment)

To fix it:

1. revert all false merges on affected repos (see affected repo list below)

2. update prow merge rule to listen to label "status/in progress", or revert name change of this label.

Affected repos (might merge PR incomplete):

reporting
examples
community
pytorch-operator
caffe2-operator
experimental-beagle
hp-tuning

Those repos are not affected due to bot user's lack of permission (include our most active repos):

kubeflow
tf-operator
testing
example-seldon
experimental-kvc
@jlewi
Copy link
Contributor

jlewi commented Apr 7, 2018

So is the plan to keep the label do-not-merge/work-in-progress ?

@jlewi
Copy link
Contributor

jlewi commented Apr 7, 2018

/assign @kunmingg

@jlewi
Copy link
Contributor

jlewi commented Apr 7, 2018

I checked kubeflow/testing - it looks like we haven't given write access to the team ci-bots instead we gave direct access to the user k8s-ci-robot. We will need to change that so those other repos are sync'd as well.

But we should wait until issues with the label sync are fixed?

@kunmingg
Copy link
Contributor Author

kunmingg commented Apr 8, 2018

Agree, easiest way is keep do-not-merge/work-in-progress label. Will add it back.
I checked recent PRs in the 7 affected repos, haven't found another false merge.
If you noticed any please let me know.

@jlewi
Copy link
Contributor

jlewi commented Apr 16, 2018

@kunmingg I think this is fixed right? Can we close it?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants