renaming top level python package (issue #914) #945
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @zabbasi, TravisCI finished with status TravisBuddy Request Identifier: 61dce690-36dd-11e9-afc2-91cde96227b3 |
Travis tests have failedHey @zabbasi, 1st Buildgometalinter --config=linter_config.json --vendor ./...goveralls -service=travis-ci -v -package ./pkg/... -ignore "pkg/client/*/*.go,pkg/client/*/*/*.go,pkg/client/*/*/*/*.go,pkg/client/*/*/*/*/*.go,pkg/client/*/*/*/*/*/*.go,pkg/client/*/*/*/*/*/*/*.go,pkg/util/testutil/*.go,pkg/apis/tensorflow/*/zz_generated.*.go,pkg/apis/tensorflow/*/*_generated.go,pkg/apis/common/*/zz_generated.*.go,pkg/apis/common/*/*_generated.go"TravisBuddy Request Identifier: c8874b90-36f8-11e9-afc2-91cde96227b3 |
|
/retest |
1 similar comment
|
/retest |
zabbasi
changed the title
|
/assign @richardsliu |
|
@jlewi Can you also take a look? Generally lgtm - but we may need to pin the version of tf-operator used in kubeflow/kubeflow to a particular commit hash or release, so that the tests are not broken. |
|
Fixes #914 |
|
/lgtm |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: richardsliu The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
This was referenced Feb 28, 2019
dsdinter
added a commit
to dsdinter/examples
that referenced
this pull request
Mar 25, 2019
Rename testing package as kubeflow/training-operator#945 Added correct path to import test framework from tf-operator
dsdinter
added a commit
to dsdinter/examples
that referenced
this pull request
May 1, 2019
Rename testing package as kubeflow/training-operator#945 Added correct path to import test framework from tf-operator
k8s-ci-robot
pushed a commit
to kubeflow/examples
that referenced
this pull request
Jun 14, 2019
* Add build and test presubmit jobs for Pytorch nmist example Keep postsubmit jobs as original release job to push images to examples registry * Refactor all jobs like mnist and GIS, will drop using release jobs * Implement test scripts and Ksonnet artifacts from mnist example to enable E2E tests * Remove release components as they are no longer used * Refactor YAML manifests as Ksonnet components * Update documentation to submit training jobs from Ksonnet * Updated to point to correct component and refactor to PytorchJob * Add seldon image build Add train CPU and GPU in jsonnet to build workflow Add Dockerfile.ksonnet and entrypoint * Commented out calls to tf-util until kubeflow/pytorch-operator#108 is implemented * Refactor to PytorchJob * Add seldon image build Add train CPU and GPU in jsonnet to build workflow Add Dockerfile.ksonnet and entrypoint * Refactor to PytorchJob * Rename workflow to avoid dns issue with "_" * Add TODO note to convert to GRPC * Rename workflow to avoid dns issue with "_" * Rename workflow to avoid dns issue with "_" * Fix path to build Seldon image in Makefile * Fix tabs in Makefile * Fix tabs in Makefile * Fix rule in Makefile * Add sleep in Makefile to wait for docker ps * Change node worker image to have docker * Remove seldon image step from Makefile Add steps to wrap model with Seldon Add boolean flag to build Seldon steps * Add step id build- in jsonnet * Skip pull step for Seldon * Fix wait for in Seldon build * Fix lint errors * Set useimagecache to false first time the pipeline is executed to avoid error * Set contextDir as absolute path for Seldon step * Remove unnecessary argument and Dockerfile in Seldon step * Add absolute path for build in Seldon steps * Include absolute path inside jsonnet hardcoded to GCB /workspace/ Remove setting rootDir from Makefile * Update images with new naming from E2E tests * Change test-worker image version * Update images with new naming from E2E tests * Set useimagecache to true now that we have first images built * Fix cachelist in Seldon build * Fix cachelist in Seldon build * Leverage tf-operator test framework for test_runner As per kubeflow/pytorch-operator#108 * Consolidate testing imports Rename testing package as kubeflow/training-operator#945 Added correct path to import test framework from tf-operator * Add test framework in PYTHONPATH in build_template * Remove old release jobs to build images * Update stepimage to same as GIS example * Bump up supported Pytorch operator versions from v1alpha2/v1beta1 to v1beta1/v1beta2 to support Kubeflow 0.5 - Refactor training manifests from v1alpha2 to v1beta2 - Update documents * Update KF cluster version to latest to run tests * Update KF cluster zone * Add pylint exception while importing test_runner class from tf-operator * Pass dummy tests to train, deploy and predict Remove no longer used test_data and conftest * Pass dummy tests to train, deploy and predict Remove no longer used test_data and conftest
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change is